Bug 201181 - InlineTextBox::end() should return first-past-end offset
Summary: InlineTextBox::end() should return first-past-end offset
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 210677
  Show dependency treegraph
 
Reported: 2019-08-27 08:05 PDT by Antti Koivisto
Modified: 2020-04-17 15:55 PDT (History)
6 users (show)

See Also:


Attachments
patch (12.77 KB, patch)
2019-08-27 08:11 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (14.20 KB, patch)
2019-08-27 08:36 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2019-08-27 08:05:40 PDT
It currently points to the last character, except for empty text boxes. This is awkward in itself and also inconsistent, as we use first-past-end offset everywhere else.
Comment 1 Antti Koivisto 2019-08-27 08:11:47 PDT
Created attachment 377340 [details]
patch
Comment 2 Antti Koivisto 2019-08-27 08:36:01 PDT
Created attachment 377341 [details]
patch
Comment 3 zalan 2019-08-27 11:11:11 PDT
Comment on attachment 377341 [details]
patch

I wonder what the reasoning was when it was introduced.
Comment 4 WebKit Commit Bot 2019-08-27 12:29:17 PDT
The commit-queue encountered the following flaky tests while processing attachment 377341 [details]:

fullscreen/full-screen-request-removed-with-raf.html bug 201188 (author: jer.noble@apple.com)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2019-08-27 12:29:59 PDT
Comment on attachment 377341 [details]
patch

Clearing flags on attachment: 377341

Committed r249160: <https://trac.webkit.org/changeset/249160>
Comment 6 WebKit Commit Bot 2019-08-27 12:30:01 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-08-27 12:32:44 PDT
<rdar://problem/54758922>