Bug 201163 – Update Test Expectations for iPad for fast/scrolling/ios/autoscroll-input-when-very-zoomed.html

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Megan Gardner]

Update Test Expectations for iPad for fast/scrolling/ios/autoscroll-input-when-very-zoomed-expected.txt

[Megan Gardner]

Created attachment 377296 [details]
Patch

[Megan Gardner]

Created attachment 377298 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 377298 [details]
Patch

Rejecting attachment 377298 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 377298, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/12970961

[Wenson Hsieh]

<rdar://problem/54727027>

[Megan Gardner]

Created attachment 377351 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 377351 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377351&action=review

> LayoutTests/ChangeLog:3
> +        Update Test Expectations for iPad for fast/scrolling/ios/autoscroll-input-when-very-zoomed-expected.txt

fast/scrolling/ios/autoscroll-input-when-very-zoomed.html

> LayoutTests/platform/ipad/fast/scrolling/ios/autoscroll-input-when-very-zoomed-expected.txt:2
> +FAIL: page has failed to scrolled on the first input

Is the plan to make the test pass, or to keep it failing? I think that once it's fixed, the shared ios expectation will work, so I'm not sure is a separate -expected.txt is needed.

[Megan Gardner]

Comment on attachment 377351 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377351&action=review

>> LayoutTests/platform/ipad/fast/scrolling/ios/autoscroll-input-when-very-zoomed-expected.txt:2
>> +FAIL: page has failed to scrolled on the first input
> 
> Is the plan to make the test pass, or to keep it failing? I think that once it's fixed, the shared ios expectation will work, so I'm not sure is a separate -expected.txt is needed.

There are no plans to change this test. It works as expected on iPhone, and has been tuned to work there. It's either have failing test expectations, or skip the test, and I feel that failing test expectations are more helpful than a skipped test, so that is what I am doing, after discussing this with Simon and Tim.

[Megan Gardner]

Created attachment 377355 [details]
Patch

[Alexey Proskuryakov]

Is this a test for functionality that is iPhone only, and doesn't exist on iPad? It doesn't sound so from the name of the test.

I men, we don't have to make this test work, but then we'd need to create a new test for iPad, won't we?

[Megan Gardner]

Then mark this test as failing on iPad; it tests an iPhone-specific behavior

[Megan Gardner]

Created attachment 377360 [details]
Patch

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 377360 [details]:

fullscreen/full-screen-request-removed-with-raf.html bug 201188 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 377360 [details]
Patch

Clearing flags on attachment: 377360

Committed r249174: <https://trac.webkit.org/changeset/249174>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.