Bug 201191 - Fix applying diffs that only change file mode
Summary: Fix applying diffs that only change file mode
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Darpinian
Keywords: InRadar
Depends on:
Blocks: webglangle 201156
  Show dependency treegraph
Reported: 2019-08-27 11:18 PDT by James Darpinian
Modified: 2020-03-11 17:12 PDT (History)
8 users (show)

See Also:

Patch (1.19 KB, patch)
2019-08-27 11:19 PDT, James Darpinian
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Darpinian 2019-08-27 11:18:44 PDT
Fix applying diffs that only change file mode
Comment 1 James Darpinian 2019-08-27 11:19:53 PDT
Created attachment 377356 [details]
Comment 2 James Darpinian 2019-08-27 11:25:54 PDT
See bug 201156 for an example of a patch that fails without this change.
Comment 3 Daniel Bates 2019-08-27 13:03:19 PDT
Comment on attachment 377356 [details]

I can't remember if we have tests for svn-apply the actually driver program. Can you please check if we do in Tools/Scripts/webkitperl? If we do then please write a test. Otherwise, this change is fine as-is since we tend not to test the driver code - we test the library code.
Comment 4 Daniel Bates 2019-08-27 13:06:24 PDT
Thanks for the patch!
Comment 5 James Darpinian 2019-08-27 16:44:03 PDT
Thanks for reviewing! I looked but don't see any tests for the svn-apply driver program itself.
Comment 6 Daniel Bates 2019-08-27 19:20:17 PDT
Comment 7 WebKit Commit Bot 2019-08-27 20:14:53 PDT
The commit-queue encountered the following flaky tests while processing attachment 377356 [details]:

fullscreen/full-screen-request-removed-with-raf.html bug 201188 (author: jer.noble@apple.com)
The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2019-08-27 20:15:40 PDT
Comment on attachment 377356 [details]

Clearing flags on attachment: 377356

Committed r249190: <https://trac.webkit.org/changeset/249190>
Comment 9 WebKit Commit Bot 2019-08-27 20:15:41 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2019-08-27 20:16:23 PDT