Bug 182571 – Flaky Test: media/modern-media-controls/tracks-support/tracks-support-show-panel-fullscreen.html

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[WebKit Commit Bot]

This is an automatically generated bug from the commit-queue.
media/modern-media-controls/tracks-support/tracks-support-show-panel-fullscreen.html has been flaky on the commit-queue.

media/modern-media-controls/tracks-support/tracks-support-show-panel-fullscreen.html was authored by [e-mail] and [e-mail].
https://trac.webkit.org/browser/trunk/LayoutTests/media/modern-media-controls/tracks-support/tracks-support-show-panel-fullscreen.html

The commit-queue just saw media/modern-media-controls/tracks-support/tracks-support-show-panel-fullscreen.html flake (test timed out) while processing attachment 333282 [details] on bug 182568.
Bot: webkit-cq-01  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.12.6

The bots will update this with information from each new failure.

If you believe this bug to be fixed or invalid, feel free to close.  The bots will re-open if the flake re-occurs.

If you would like to track this test fix with another bug, please close this bug as a duplicate.  The bots will follow the duplicate chain when making future comments.

[WebKit Commit Bot]

Created attachment 333285 [details]
Archive of layout-test-results from webkit-cq-01

[Ryan Haddad]

This test is a flaky timeout on High Sierra Debug WK1 and Sierra Release WK1.

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Ftracks-support%2Ftracks-support-show-panel-fullscreen.html

[WebKit Commit Bot]

The commit-queue just saw media/modern-media-controls/tracks-support/tracks-support-show-panel-fullscreen.html flake (test timed out) while processing attachment 333402 [details] on bug 182607.
Bot: webkit-cq-01  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.12.6

[WebKit Commit Bot]

Created attachment 333411 [details]
Archive of layout-test-results from webkit-cq-01

[Ryan Haddad]

Marked test as flaky on WK1 in https://trac.webkit.org/r228291

[Shawn Roberts]

updated to mark flaky on all of Mac as it's now affecting Mojave and WK2

[Shawn Roberts]

Created attachment 361460 [details]
Patch

[EWS Watchlist]

Attachment 361460 [details] did not pass style-queue:


ERROR: LayoutTests/platform/mac/TestExpectations:1803:  Unrecognized modifier 'mac'  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/mac/TestExpectations:1803:  Unrecognized modifier 'mac'  [test/expectations] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Shawn Roberts]

Created attachment 361461 [details]
Patch

[Alexey Proskuryakov]

*** Bug 206631 has been marked as a duplicate of this bug. ***

[Alexey Proskuryakov]

<rdar://problem/58817580>

[Jacob Uphoff]

Set expectations to include wk2. https://trac.webkit.org/changeset/259723/webkit

[Peng Liu]

*** This bug has been marked as a duplicate of bug 211645 ***

[Ryan Haddad]

Reopening because this test is still a flaky timeout on the bots after the fix for bug 211645

[Ryan Haddad]

(In reply to Ryan Haddad from comment #14)
> Reopening because this test is still a flaky timeout on the bots after the
> fix for bug 211645
Specifically, it continues to time out on Catalina and Mojave Debug queues.

[Ryan Haddad]

I marked it as flaky again in r261704.

[Peng Liu]

Created attachment 399713 [details]
Add an explicit timeout in the test to debug the flaky timeout

[EWS]

Committed r261852: <https://trac.webkit.org/changeset/261852>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399713 [details].

[Peng Liu]

Reopen this bug to investigate the failure instead of timeout on bots after r261852.

[Peng Liu]

The diff is below:

@@ -9,10 +9,7 @@
 PASS internals.shadowRoot(media).querySelector("button.tracks") became different from null
 PASS internals.shadowRoot(media).querySelector("button.tracks").getBoundingClientRect().width became different from 0
 PASS internals.shadowRoot(media).querySelector("button.tracks").getBoundingClientRect().right became 582
-PASS internals.shadowRoot(media).querySelector('.tracks-panel') became different from null
-PASS internals.shadowRoot(media).querySelector('.tracks-panel').style.right is "218px"
-PASS internals.shadowRoot(media).querySelector('.tracks-panel').style.bottom is "101px"
-
+FAIL: did not end fast enough
 PASS successfullyParsed is true
 
 TEST COMPLETE

[Robert Jenner]

Timeout expectation set in previous patch was causing the test to be more flakey. Removed timeout test expectation from log in bug: 
https://bugs.webkit.org/show_bug.cgi?id=222117

[Peng Liu]

*** This bug has been marked as a duplicate of bug 169158 ***

[Peng Liu]

It was a mistake to mark this bug as a duplicate.

[Peng Liu]

Created attachment 421581 [details]
Patch

[EWS]

Committed r273591: <https://commits.webkit.org/r273591>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421581 [details].