Bug 222117 - REGRESSION (r273004): [ macOS ] media/modern-media-controls/volume-support/volume-support-drag.html is a flakey text failure
Summary: REGRESSION (r273004): [ macOS ] media/modern-media-controls/volume-support/vo...
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
Keywords: InRadar
Depends on:
Reported: 2021-02-18 10:44 PST by Robert Jenner
Modified: 2021-02-23 17:41 PST (History)
10 users (show)

See Also:

Update TestExpectations (2.42 KB, patch)
2021-02-18 15:25 PST, Robert Jenner
no flags Details | Formatted Diff | Diff
Patch (3.21 KB, patch)
2021-02-23 16:08 PST, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (3.25 KB, patch)
2021-02-23 17:10 PST, Devin Rousso
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (3.24 KB, patch)
2021-02-23 17:12 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Jenner 2021-02-18 10:44:29 PST

is a flakey text failure in macOS. 



@@ -6,19 +6,15 @@
 By default, the volume slider should be set to 0 because the media is muted
 PASS mediaController.controls.volumeSlider.value is 0
 PASS muteButton.getBoundingClientRect().width became different from 0
-PASS volumeSlider.getBoundingClientRect().width became different from 0
-Before starting to drag the volume slider, the media should be muted still
-PASS media.muted is true
-We initiated a volume slider drag, the media should no longer be muted and the volume set
-PASS media.muted became false
-PASS media.volume became 0.51
-We finished dragging to set the volume to 1
-PASS media.volume became 1
-PASS mediaController.controls.volumeSlider.parent.visible is true
 PASS successfullyParsed is true

Have not reproduced yet. However, history points to flakey failures starting at r273004. There do appear to be related changes at that revision.
Comment 1 Radar WebKit Bug Importer 2021-02-18 10:44:46 PST
Comment 2 Robert Jenner 2021-02-18 11:46:28 PST
Reproduced failure at tip of tree, and by reverting checkout to r273004, and running test: 

run-webkit-test media/modern-media-controls/volume-support/volume-support-drag.html --iterations 100 -f

Ran same test at r273003 checkout, and the failure was not reproducible.
Comment 3 Robert Jenner 2021-02-18 15:04:20 PST

Is a similar test that is failing at the same regression point.
Comment 4 Robert Jenner 2021-02-18 15:25:25 PST
Created attachment 420879 [details]
Update TestExpectations
Comment 5 Truitt Savell 2021-02-18 15:28:35 PST
Comment on attachment 420879 [details]
Update TestExpectations

Clearing flags on attachment: 420879

Committed r273105 (234303@main): <https://commits.webkit.org/234303@main>
Comment 6 Devin Rousso 2021-02-23 16:08:07 PST
Created attachment 421364 [details]
Comment 7 Devin Rousso 2021-02-23 17:10:13 PST
Created attachment 421373 [details]
Comment 8 EWS 2021-02-23 17:11:06 PST
/Volumes/Data/worker/Commit-Queue/build/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 9 Devin Rousso 2021-02-23 17:12:10 PST
Created attachment 421375 [details]
Comment 10 EWS 2021-02-23 17:41:36 PST
Committed r273366: <https://commits.webkit.org/r273366>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421375 [details].