Bug 222134 - [ macOS ] media/modern-media-controls/tracks-support/mac/tracks-support-show-panel-fullscreen.html is a flakey text failure
Summary: [ macOS ] media/modern-media-controls/tracks-support/mac/tracks-support-show-...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-18 14:37 PST by Robert Jenner
Modified: 2021-02-25 16:14 PST (History)
9 users (show)

See Also:


Attachments
Patch (3.78 KB, patch)
2021-02-23 16:14 PST, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (3.81 KB, patch)
2021-02-23 17:10 PST, Devin Rousso
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (3.80 KB, patch)
2021-02-23 17:12 PST, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (3.83 KB, patch)
2021-02-23 17:46 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Jenner 2021-02-18 14:37:14 PST
media/modern-media-controls/tracks-support/mac/tracks-support-show-panel-fullscreen.html

is a flakey text failure in macOS. 

HISTORY URL:
https://results.webkit.org/?suite=layout-tests&test=media%2Fmodern-media-controls%2Ftracks-support%2Fmac%2Ftracks-support-show-panel-fullscreen.html

DIFF URL:
https://build.webkit.org/results/Apple-BigSur-Release-WK2-Tests/r273093%20(320)/media/modern-media-controls/tracks-support/mac/tracks-support-show-panel-fullscreen-pretty-diff.html

DIFF TEXT:
@@ -9,10 +9,7 @@
 PASS internals.shadowRoot(media).querySelector("button.tracks") became different from null
 PASS internals.shadowRoot(media).querySelector("button.tracks").getBoundingClientRect().width became different from 0
 PASS internals.shadowRoot(media).querySelector("button.tracks").getBoundingClientRect().right became 582
-PASS internals.shadowRoot(media).querySelector('.tracks-panel') became different from null
-PASS internals.shadowRoot(media).querySelector('.tracks-panel').style.right is "218px"
-PASS internals.shadowRoot(media).querySelector('.tracks-panel').style.bottom is "101px"
-
+FAIL: did not end fast enough
 PASS successfullyParsed is true
 
 TEST COMPLETE
Comment 1 Radar WebKit Bug Importer 2021-02-18 14:37:32 PST
<rdar://problem/74494853>
Comment 2 Devin Rousso 2021-02-23 16:14:18 PST
Created attachment 421366 [details]
Patch
Comment 3 Devin Rousso 2021-02-23 17:10:02 PST
Created attachment 421372 [details]
Patch
Comment 4 EWS 2021-02-23 17:11:00 PST
/Volumes/Data/worker/Commit-Queue/build/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 5 Devin Rousso 2021-02-23 17:12:00 PST
Created attachment 421374 [details]
Patch
Comment 6 EWS 2021-02-23 17:42:40 PST
Tools/Scripts/svn-apply failed to apply attachment 421374 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 7 Devin Rousso 2021-02-23 17:46:43 PST
Created attachment 421379 [details]
Patch
Comment 8 EWS 2021-02-23 18:11:46 PST
commit-queue failed to commit attachment 421379 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 9 EWS 2021-02-23 18:41:33 PST
Committed r273368: <https://commits.webkit.org/r273368>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421379 [details].