WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 182607
[RenderTreeBuilder] Do not use RenderTreeBuilder::current() in RenderRubyRun::takeChild
https://bugs.webkit.org/show_bug.cgi?id=182607
Summary
[RenderTreeBuilder] Do not use RenderTreeBuilder::current() in RenderRubyRun:...
zalan
Reported
2018-02-08 10:07:31 PST
we've got the builder argument.
Attachments
Patch
(1.79 KB, patch)
2018-02-08 10:12 PST
,
zalan
no flags
Details
Formatted Diff
Diff
Patch
(1.75 KB, patch)
2018-02-08 12:00 PST
,
zalan
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2018-02-08 10:08:03 PST
<
rdar://problem/37355944
>
zalan
Comment 2
2018-02-08 10:12:03 PST
Created
attachment 333384
[details]
Patch
WebKit Commit Bot
Comment 3
2018-02-08 11:48:53 PST
Comment on
attachment 333384
[details]
Patch Rejecting
attachment 333384
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 333384, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: u'Sam Weinig']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/rendering/RenderRubyRun.cpp Hunk #1 FAILED at 110. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/RenderRubyRun.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Sam Weinig']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output:
http://webkit-queues.webkit.org/results/6418483
zalan
Comment 4
2018-02-08 12:00:50 PST
Created
attachment 333402
[details]
Patch
WebKit Commit Bot
Comment 5
2018-02-08 12:49:26 PST
The commit-queue encountered the following flaky tests while processing
attachment 333402
[details]
: media/modern-media-controls/tracks-support/tracks-support-show-panel-fullscreen.html
bug 182571
(authors:
graouts@apple.com
and
ryanhaddad@apple.com
) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6
2018-02-08 12:49:55 PST
Comment on
attachment 333402
[details]
Patch Clearing flags on attachment: 333402 Committed
r228289
: <
https://trac.webkit.org/changeset/228289
>
WebKit Commit Bot
Comment 7
2018-02-08 12:49:56 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug