Bug 165279 - AX: Consider implementing @inert (affects keyboard, events, and accessibility)
Summary: AX: Consider implementing @inert (affects keyboard, events, and accessibility)
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
: 159748 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-12-01 14:31 PST by James Craig
Modified: 2020-05-25 14:08 PDT (History)
15 users (show)

See Also:


Attachments
testcase (5.02 KB, text/html)
2020-04-16 07:43 PDT, Frédéric Wang (:fredw)
no flags Details
WIP Patch (4.57 KB, patch)
2020-04-16 07:47 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Craig 2016-12-01 14:31:39 PST
WICG discussion happening here:

https://discourse.wicg.io/t/inert-attribute/1838
Comment 1 Radar WebKit Bug Importer 2016-12-01 14:32:16 PST
<rdar://problem/29467435>
Comment 2 James Craig 2016-12-01 15:28:40 PST
There are obvious benefits for accessibility. 

Are there concerns from WebKit implementors about the functionality change or implementability of for events handling and keyboard/focus behavior?
Comment 3 James Craig 2016-12-01 15:52:47 PST
Also discussion re: naming conflict with template: https://github.com/WICG/inert/issues/39
Comment 4 James Craig 2016-12-08 18:54:45 PST
*** Bug 159748 has been marked as a duplicate of this bug. ***
Comment 5 James Craig 2016-12-08 18:59:03 PST
Relating to <dialog> bug 84635
Comment 6 Chris Rebert 2016-12-08 19:50:48 PST
See also: https://github.com/whatwg/html/pull/1474
Comment 7 James Craig 2017-05-27 00:50:26 PDT
Google this shipping behind a flag now.

Enable:
chrome://flags#enable-experimental-web-platform-features

Explainer:
https://github.com/WICG/inert/blob/master/README.md

Chrome "Intent to Implement" from February:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/N--HhuYFJQI
Comment 8 Carolyn MacLeod 2017-10-06 19:11:24 PDT
FF bug was reopened in May/17: https://bugzilla.mozilla.org/show_bug.cgi?id=921504

Edge bug opened in Sept/17 (already has 187 votes): https://wpdev.uservoice.com/forums/257854-microsoft-edge-developer/suggestions/31606522-support-the-inert-attribute
Comment 9 Michael Puckett 2018-09-03 05:44:42 PDT
Please consider adding to the feature status list here:

https://webkit.org/status
Comment 10 Frédéric Wang (:fredw) 2020-04-16 07:43:38 PDT
Created attachment 396647 [details]
testcase
Comment 11 Frédéric Wang (:fredw) 2020-04-16 07:47:18 PDT
Created attachment 396649 [details]
WIP Patch

Just a quick proof-of-concept patch. It seems to at least work for links. Probably there are several cases to check and things to verify, but that gives a starting point.
Comment 12 Frédéric Wang (:fredw) 2020-04-16 07:52:27 PDT
Comment on attachment 396649 [details]
WIP Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396649&action=review

> Source/WebCore/dom/Element.h:473
> +    virtual bool isDisabledFormControl() const { return isInert(); }

Obviously, this should also be done in derived class... it seems they don't call their parent.