Bug 230680 - AX: Split out isInert from isAXHidden on AccessibilityObject
Summary: AX: Split out isInert from isAXHidden on AccessibilityObject
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Tim Nguyen (:ntim)
Keywords: InRadar
Depends on: 230690
Blocks: dialog-element 165279
  Show dependency treegraph
Reported: 2021-09-23 02:01 PDT by Tim Nguyen (:ntim)
Modified: 2021-09-23 07:25 PDT (History)
11 users (show)

See Also:

Patch (5.60 KB, patch)
2021-09-23 02:07 PDT, Tim Nguyen (:ntim)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2021-09-23 02:01:10 PDT
Reasons to do this are:
* Naming of isAXHidden is a bit of a lie
* We don't want to inherit inert state from parent to child, like we do for aria-hidden
Comment 1 Radar WebKit Bug Importer 2021-09-23 02:01:25 PDT
Comment 2 Tim Nguyen (:ntim) 2021-09-23 02:07:18 PDT
Created attachment 439027 [details]
Comment 3 EWS 2021-09-23 04:55:02 PDT
Committed r282956 (242046@main): <https://commits.webkit.org/242046@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439027 [details].
Comment 4 Andres Gonzalez 2021-09-23 06:40:45 PDT
(In reply to Tim Nguyen (:ntim) from comment #2)
> Created attachment 439027 [details]
> Patch

Can we add the check for isInert to AccessibilityObject::ignoredFromModalPresence instead? No need to expose isInert in the AXCoreObject interface, so it should be removed from there and from AXIsolatedObject. While you are at it, could you please also remove ignoredFromModalPresence from the AXCoreObject interface and make it a virtual in AccessibilityObject? And also remove it from AXIsolatedObject. Thanks.