Selection changes on modal <dialog> text nodes do not work with the mouse

[Tim Nguyen (:ntim)]

I suspect there's a bug with how text selection on inert is implemented.

[Radar WebKit Bug Importer]

<rdar://problem/84342457>

[Tim Nguyen (:ntim)]

Created attachment 441575 [details]
Patch

[Antti Koivisto]

Comment on attachment 441575 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441575&action=review

> Source/WebCore/rendering/style/RenderStyle.h:613
> +    UserSelect effectiveUserSelect() const { return effectiveInert() ? UserSelect::None : userSelect(); }

It is confusing since "effectiveUserSelect" sounds like a property but this is just a helper.

Perhaps

bool allowsSelections() const;

or similar. It would also be good to start moving helpers out of RenderStyle

inline bool allowsSelections(const RenderStyle&)

would be another option.

[Antti Koivisto]

Comment on attachment 441575 [details]
Patch

r=me but please find a better name

[Tim Nguyen (:ntim)]

Created attachment 441591 [details]
Patch

[Tim Nguyen (:ntim)]

Committed r284366 (243151@main): <https://commits.webkit.org/243151@main>