RESOLVED FIXED 229728
Add more inert checks for selection-related functionality 
https://bugs.webkit.org/show_bug.cgi?id=229728
Summary Add more inert checks for selection-related functionality
Attachments
Patch (4.49 KB, patch)
2021-09-01 05:26 PDT, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
Patch (6.15 KB, patch)
2021-09-01 05:36 PDT, Tim Nguyen (:ntim) 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (6.69 KB, patch)
2021-09-01 05:48 PDT, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
Patch (8.29 KB, patch)
2021-09-01 09:18 PDT, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
Patch (14.54 KB, patch)
2021-09-02 08:56 PDT, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Tim Nguyen (:ntim)
Comment 1 2021-09-01 05:26:37 PDT
Created attachment 437020 [details] Patch
Tim Nguyen (:ntim)
Comment 2 2021-09-01 05:36:54 PDT
Created attachment 437021 [details] Patch
Tim Nguyen (:ntim)
Comment 3 2021-09-01 05:48:51 PDT
Created attachment 437022 [details] Patch
Tim Nguyen (:ntim)
Comment 4 2021-09-01 09:18:37 PDT
Created attachment 437036 [details] Patch
Antti Koivisto
Comment 5 2021-09-02 07:59:03 PDT
Comment on attachment 437036 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437036&action=review > Source/WebCore/dom/Position.cpp:945 > bool Position::nodeIsUserSelectNone(Node* node) > { > - return node && node->renderer() && node->renderer()->style().userSelect() == UserSelect::None; > + if (!node) > + return false; > + if (node->isInert()) > + return true; > + return node->renderer() && node->renderer()->style().userSelect() == UserSelect::None; > } The name of the function no longer matches what it does ("nodeIsInertOrUserSelectNone"). How about renaming it to something more accurate?
Tim Nguyen (:ntim)
Comment 6 2021-09-02 08:56:12 PDT
Created attachment 437156 [details] Patch
EWS
Comment 7 2021-09-02 09:39:55 PDT
Committed r281930 (241239@main): <https://commits.webkit.org/241239@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437156 [details].
Radar WebKit Bug Importer
Comment 8 2021-09-02 09:40:47 PDT
<rdar://problem/82679366>
Note You need to log in before you can comment on or make changes to this bug.