Bug 155322 – Tracking bug for CG asynchronous image decoding

• Status: RESOLVED
• Resolution: FIXED
• Component: Images

[Said Abou-Hallawa]

Tracking bug for forking the image decoding into two separate paths:

1. Synchronous: This is the current implementation where the image decoding usually happens in the whippet thread when an image drawing command is pushed into the CG context.
2. Asynchronous: This is a new mode where an image decoding will start immediately after receiving the first chunk of the encoded image date. And to not block the main thread, this image decoding has to run on a separate thread.

[Said Abou-Hallawa]

Created attachment 273794 [details]
Patch

[Said Abou-Hallawa]

This patch is not for review. I am planning to split it into sub patches for review. The purpose of this patch is to fix the build breaks and the test failures.

[Said Abou-Hallawa]

Created attachment 273795 [details]
Patch

[Said Abou-Hallawa]

Created attachment 273797 [details]
Patch

[Said Abou-Hallawa]

Created attachment 273799 [details]
Patch

[Said Abou-Hallawa]

Created attachment 273800 [details]
Patch

[Said Abou-Hallawa]

Created attachment 273801 [details]
Patch

[Said Abou-Hallawa]

Created attachment 273802 [details]
Patch

[Said Abou-Hallawa]

Created attachment 273805 [details]
Patch

[Said Abou-Hallawa]

Created attachment 273810 [details]
Patch

[Build Bot]

Comment on attachment 273810 [details]
Patch

Attachment 273810 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/964479

New failing tests:
transitions/extra-transition.html
svg/carto.net/scrollbar.svg

[Build Bot]

Created attachment 273816 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 273810 [details]
Patch

Attachment 273810 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/964779

New failing tests:
svg/carto.net/scrollbar.svg

[Build Bot]

Created attachment 273820 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Said Abou-Hallawa]

Created attachment 273826 [details]
Patch

[Said Abou-Hallawa]

Created attachment 273828 [details]
Patch

[Build Bot]

Comment on attachment 273828 [details]
Patch

Attachment 273828 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/965531

New failing tests:
transitions/extra-transition.html

[Build Bot]

Created attachment 273831 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 273828 [details]
Patch

Attachment 273828 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/965991

New failing tests:
transitions/extra-transition.html
svg/carto.net/scrollbar.svg

[Build Bot]

Created attachment 273834 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Said Abou-Hallawa]

Created attachment 273838 [details]
Patch

[Build Bot]

Comment on attachment 273838 [details]
Patch

Attachment 273838 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/967075

New failing tests:
transitions/extra-transition.html
svg/carto.net/scrollbar.svg

[Build Bot]

Created attachment 273841 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 273838 [details]
Patch

Attachment 273838 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/967089

New failing tests:
transitions/extra-transition.html
svg/carto.net/scrollbar.svg

[Build Bot]

Created attachment 273842 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Said Abou-Hallawa]

Created attachment 273847 [details]
Patch

[Build Bot]

Comment on attachment 273847 [details]
Patch

Attachment 273847 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/967979

New failing tests:
transitions/extra-transition.html
svg/carto.net/scrollbar.svg

[Build Bot]

Created attachment 273851 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 273847 [details]
Patch

Attachment 273847 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/968016

New failing tests:
transitions/extra-transition.html
svg/carto.net/scrollbar.svg

[Build Bot]

Created attachment 273855 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Said Abou-Hallawa]

Created attachment 273866 [details]
Patch

[Said Abou-Hallawa]

Created attachment 273867 [details]
Patch

[Build Bot]

Comment on attachment 273867 [details]
Patch

Attachment 273867 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/969595

New failing tests:
fast/images/gif-large-checkerboard.html
transitions/extra-transition.html
svg/carto.net/scrollbar.svg

[Build Bot]

Created attachment 273869 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 273867 [details]
Patch

Attachment 273867 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/969610

New failing tests:
transitions/extra-transition.html

[Build Bot]

Created attachment 273870 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Said Abou-Hallawa]

Created attachment 273871 [details]
Patch

[Build Bot]

Comment on attachment 273871 [details]
Patch

Attachment 273871 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/969872

New failing tests:
transitions/extra-transition.html

[Build Bot]

Created attachment 273872 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Said Abou-Hallawa]

Created attachment 273873 [details]
Patch

[Build Bot]

Comment on attachment 273873 [details]
Patch

Attachment 273873 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/970068

New failing tests:
svg/carto.net/scrollbar.svg

[Build Bot]

Created attachment 273877 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 273873 [details]
Patch

Attachment 273873 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/970101

New failing tests:
transitions/extra-transition.html

[Build Bot]

Created attachment 273878 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Said Abou-Hallawa]

Created attachment 273880 [details]
Patch

[Build Bot]

Comment on attachment 273880 [details]
Patch

Attachment 273880 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/970432

New failing tests:
transitions/extra-transition.html
fast/images/gif-short-app-extension-string.html

[Build Bot]

Created attachment 273883 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Said Abou-Hallawa]

Created attachment 273888 [details]
Patch

[Said Abou-Hallawa]

The asynchronous image decoding feature was implemented and has been enabled in WebKit. What is left here is fixing regular bugs. So resolve this bug as Fixed.