Bug 159795 - Make ImageFrame and ImageFrameData be equivalent so ImageFrameData can be removed
Summary: Make ImageFrame and ImageFrameData be equivalent so ImageFrameData can be rem...
Status: RESOLVED DUPLICATE of bug 159819
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords:
Depends on: 159721
Blocks: 155322 159819
  Show dependency tree / graph
 
Reported: 2016-07-14 16:59 PDT by Said Abou-Hallawa
Modified: 2017-08-21 12:15 PDT (History)
4 users (show)

See Also:

Attachments
Patch (205.81 KB, patch)
2016-07-14 17:27 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (205.79 KB, patch)
2016-07-14 17:56 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (205.79 KB, patch)
2016-07-14 18:28 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (205.79 KB, patch)
2016-07-14 18:37 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch for review (57.78 KB, patch)
2016-07-15 10:15 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2016-07-14 16:59:23 PDT 
This step will allow removing ImageFrame from platform/image-decoders/ImageDecoder.h and renaming ImageFrameData to be ImageFrame.
Comment 1 Said Abou-Hallawa 2016-07-14 17:27:58 PDT 
Created attachment 283714 [details]
Patch
Comment 2 Said Abou-Hallawa 2016-07-14 17:56:35 PDT 
Created attachment 283721 [details]
Patch
Comment 3 Said Abou-Hallawa 2016-07-14 18:28:54 PDT 
Created attachment 283726 [details]
Patch
Comment 4 Said Abou-Hallawa 2016-07-14 18:37:15 PDT 
Created attachment 283729 [details]
Patch
Comment 5 Said Abou-Hallawa 2016-07-15 10:15:15 PDT 
Created attachment 283769 [details]
Patch for review
Comment 6 Said Abou-Hallawa 2016-09-15 14:28:31 PDT 
https://bugs.webkit.org/show_bug.cgi?id=159819

*** This bug has been marked as a duplicate of bug 159819 ***
Comment 7 Brady Eidson 2017-08-19 16:02:38 PDT 
Comment on attachment 283769 [details]
Patch for review

r-, as this has been pending review for over a year now. It is near-impossible that this patch still applies to trunk and unlikely to still be relevant in its current form.
Comment 8 Said Abou-Hallawa 2017-08-21 12:15:27 PDT 
Comment on attachment 283769 [details]
Patch for review

This bug was marked as s duplicate. I was not aware that duplicate bugs can also appear as requesting-review bugs. I think removing the flags is more appropriate in this case.