Bug 155566 – Make the ImageFrameDecoder notify the image observer when a frame image finishes decoding

• Status: RESOLVED
• Resolution: INVALID
• Component: Images

[Said Abou-Hallawa]

With the synchronous image, CachedImage::finishLoading() notifies the observers (which are the renderers) by calling CachedImage::notifyObservers(). With the asynchronous we need to do the same when a frame image finished decoding. Since ImageSource has a reference to an Image object, and the Image::m_observer is actually an instance of CachedImage, the calling sequence should be straightforward.

[Said Abou-Hallawa]

Created attachment 274237 [details]
Patch

[Said Abou-Hallawa]

Created attachment 274250 [details]
Patch for review

[Simon Fraser (smfr)]

Comment on attachment 274250 [details]
Patch for review

View in context: https://bugs.webkit.org/attachment.cgi?id=274250&action=review

> Source/WebCore/loader/cache/CachedImage.cpp:482
> +void CachedImage::decodedImageChanged(const Image* image)

Can this be a const Image&?

[Brady Eidson]

Comment on attachment 274250 [details]
Patch for review

r-, as this has been pending review for over a year now. It is near-impossible that this patch still applies to trunk and unlikely to still be relevant in its current form.

[Said Abou-Hallawa]

Comment on attachment 274250 [details]
Patch for review

This bug was marked as s invalid. I was not aware that duplicate bugs can also appear as requesting-review bugs. I think removing the flags is more appropriate in this case.