Bug 155997 - REGRESSION (r198782): CGImageSourceUpdateData() is called twice with the same data every time ImageSource::setData() is called
Summary: REGRESSION (r198782): CGImageSourceUpdateData() is called twice with the same...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
Keywords: InRadar, Regression
Depends on:
Blocks: 155322
  Show dependency treegraph
Reported: 2016-03-29 16:51 PDT by Said Abou-Hallawa
Modified: 2016-04-22 13:09 PDT (History)
4 users (show)

See Also:

Patch (1.53 KB, patch)
2016-03-29 17:12 PDT, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2016-03-29 16:51:23 PDT
This bug causes logging an error message saying "CGImageSourceUpdateData image source was already finalized".

When refactoring the code of ImageSource::setData(SharedBuffer* data), I moved its code to ImageDecoder::setData(SharedBuffer* data). And as a preparation for the asynchronous image decoding work, I added another ImageDecoder::setData(CFDataRef data), and I intended to call it from ImageDecoder::setData(SharedBuffer* data) for now and then I am going to call it also from the asynchronous image decoding code path.

The bug is I left the old CGImageSourceUpdateData() in ImageDecoder::setData(SharedBuffer* data) after calling ImageDecoder::setData(CFDataRef data).
Comment 1 Joseph Pecoraro 2016-03-29 17:04:42 PDT
Comment 2 Said Abou-Hallawa 2016-03-29 17:12:56 PDT
Created attachment 275157 [details]
Comment 3 WebKit Commit Bot 2016-03-29 18:31:32 PDT
Comment on attachment 275157 [details]

Clearing flags on attachment: 275157

Committed r198818: <http://trac.webkit.org/changeset/198818>
Comment 4 WebKit Commit Bot 2016-03-29 18:31:36 PDT
All reviewed patches have been landed.  Closing bug.