Bug 141625 – UMBRELLA: Consolidate duplicate soft-linked functions

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[David Kilzer (:ddkilzer)]

Consolidating duplicate soft-linked functions would remove duplicate code created for each function, and remove/consolidate some static pointers that would cause dirty pages when the soft-linked method is used.

Here's a rough estimation of the current duplicate functions:

$ grep -r 'SOFT_LINK(' Source/WebCore | cut -d, -f2 | sed -e 's/^ *//' -e 's/ *$//' | sort | uniq -c | sort -n

   2 CMNotificationCenterAddListener
   2 CMNotificationCenterGetDefaultLocalCenter
   2 CMNotificationCenterRemoveListener
   2 CMTimeCompare
   2 CMTimeCopyAsDictionary
   2 CMTimeRangeGetEnd
   2 CloseThemeData
   2 DrawThemeBackground
   2 IsThemeActive
   2 IsThemeBackgroundPartiallyTransparent
   2 OpenThemeData
   2 QTMakeTime
   2 paintThemePart
   3 CMSampleBufferGetPresentationTimeStamp
   3 CMTimeMake
   3 CMTimebaseGetTime
   4 CMSampleBufferGetFormatDescription
   4 CMTimeGetSeconds
   4 CMTimeMakeWithSeconds
   4 UTTypeCopyPreferredTagWithClass
   4 UTTypeCreatePreferredIdentifierForTag

I'm not sure how much code space each method takes, though.

[David Kilzer (:ddkilzer)]

This strategy also saves redundant code from duplicate statements like this:

SOFT_LINK_FRAMEWORK(CoreMedia)

[David Kilzer (:ddkilzer)]

First pass at consolidating one function:

Bug 141655: Consolidate soft-linked CMTimeMakeWithSeconds() function

[David Kilzer (:ddkilzer)]

All the dependent bugs are complete.  Moving to RESOLVED/FIXED.