Bug 193568 - Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
Summary: Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSof...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks: 141625
  Show dependency tree / graph
 
Reported: 2019-01-18 03:20 PST by David Kilzer (:ddkilzer)
Modified: 2019-01-18 15:42 PST (History)
4 users (show)

See Also:

Attachments
Patch v1 (75.39 KB, patch)
2019-01-18 04:24 PST, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Patch v2 (75.64 KB, patch)
2019-01-18 08:15 PST, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2019-01-18 03:20:23 PST 
Switch remaining UIKit soft-linking in WebCore over to UIKitSoftLink.{cpp,h}.

This gets rid of 16 instances of duplicate soft-linking code for UIKit.framework.
Comment 1 Radar WebKit Bug Importer 2019-01-18 03:23:42 PST 
<rdar://problem/47381130>
Comment 2 David Kilzer (:ddkilzer) 2019-01-18 04:24:19 PST 
Created attachment 359472 [details]
Patch v1
Comment 3 David Kilzer (:ddkilzer) 2019-01-18 04:25:14 PST 
(In reply to David Kilzer (:ddkilzer) from comment #0)
> Switch remaining UIKit soft-linking in WebCore over to UIKitSoftLink.{cpp,h}.
> 
> This gets rid of 16 instances of duplicate soft-linking code for
> UIKit.framework.

Now 17 instances because I fixed WebView.mm in WebKitLegacy, too!
Comment 4 David Kilzer (:ddkilzer) 2019-01-18 08:15:58 PST 
Created attachment 359491 [details]
Patch v2
Comment 5 WebKit Commit Bot 2019-01-18 12:42:05 PST 
Comment on attachment 359491 [details]
Patch v2

Clearing flags on attachment: 359491

Committed r240168: <https://trac.webkit.org/changeset/240168>
Comment 6 WebKit Commit Bot 2019-01-18 12:42:06 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 David Kilzer (:ddkilzer) 2019-01-18 13:17:15 PST 
(In reply to WebKit Commit Bot from comment #5)
> Comment on attachment 359491 [details]
> Patch v2
> 
> Clearing flags on attachment: 359491
> 
> Committed r240168: <https://trac.webkit.org/changeset/240168>

Follow-up build fix:

Committed r240169: <https://trac.webkit.org/changeset/240169>
Comment 8 David Kilzer (:ddkilzer) 2019-01-18 15:42:08 PST 
(In reply to David Kilzer (:ddkilzer) from comment #7)
> (In reply to WebKit Commit Bot from comment #5)
> > Comment on attachment 359491 [details]
> > Patch v2
> > 
> > Clearing flags on attachment: 359491
> > 
> > Committed r240168: <https://trac.webkit.org/changeset/240168>
> 
> Follow-up build fix:
> 
> Committed r240169: <https://trac.webkit.org/changeset/240169>

A second follow-up build fix:

Committed r240183: <https://trac.webkit.org/changeset/240183>