RESOLVED FIXED 193568
Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h} 
https://bugs.webkit.org/show_bug.cgi?id=193568
Summary Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSof...
David Kilzer (:ddkilzer)
Reported 2019-01-18 03:20:23 PST
Switch remaining UIKit soft-linking in WebCore over to UIKitSoftLink.{cpp,h}. This gets rid of 16 instances of duplicate soft-linking code for UIKit.framework.
Attachments
Patch v1 (75.39 KB, patch)
2019-01-18 04:24 PST, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Patch v2 (75.64 KB, patch)
2019-01-18 08:15 PST, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-01-18 03:23:42 PST
<rdar://problem/47381130>
David Kilzer (:ddkilzer)
Comment 2 2019-01-18 04:24:19 PST
Created attachment 359472 [details] Patch v1
David Kilzer (:ddkilzer)
Comment 3 2019-01-18 04:25:14 PST
(In reply to David Kilzer (:ddkilzer) from comment #0) > Switch remaining UIKit soft-linking in WebCore over to UIKitSoftLink.{cpp,h}. > > This gets rid of 16 instances of duplicate soft-linking code for > UIKit.framework. Now 17 instances because I fixed WebView.mm in WebKitLegacy, too!
David Kilzer (:ddkilzer)
Comment 4 2019-01-18 08:15:58 PST
Created attachment 359491 [details] Patch v2
WebKit Commit Bot
Comment 5 2019-01-18 12:42:05 PST
Comment on attachment 359491 [details] Patch v2 Clearing flags on attachment: 359491 Committed r240168: <https://trac.webkit.org/changeset/240168>
WebKit Commit Bot
Comment 6 2019-01-18 12:42:06 PST
All reviewed patches have been landed. Closing bug.
David Kilzer (:ddkilzer)
Comment 7 2019-01-18 13:17:15 PST
(In reply to WebKit Commit Bot from comment #5) > Comment on attachment 359491 [details] > Patch v2 > > Clearing flags on attachment: 359491 > > Committed r240168: <https://trac.webkit.org/changeset/240168> Follow-up build fix: Committed r240169: <https://trac.webkit.org/changeset/240169>
David Kilzer (:ddkilzer)
Comment 8 2019-01-18 15:42:08 PST
(In reply to David Kilzer (:ddkilzer) from comment #7) > (In reply to WebKit Commit Bot from comment #5) > > Comment on attachment 359491 [details] > > Patch v2 > > > > Clearing flags on attachment: 359491 > > > > Committed r240168: <https://trac.webkit.org/changeset/240168> > > Follow-up build fix: > > Committed r240169: <https://trac.webkit.org/changeset/240169> A second follow-up build fix: Committed r240183: <https://trac.webkit.org/changeset/240183>
Note You need to log in before you can comment on or make changes to this bug.