Switch remaining CoreMedia soft-linking in WebCore over to CoreMediaSoftLink.{cpp,h}.
Created attachment 247058 [details] Patch v1 (in-progress; checking EWS)
Attachment 247058 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:50: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:50: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:48: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:54: Bad include order. Mixing system and custom headers. [build/include_order] [4] Total errors found: 4 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 247059 [details] Patch v2 (in-progress; checking EWS)
Attachment 247059 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:50: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:50: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:48: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:54: Bad include order. Mixing system and custom headers. [build/include_order] [4] Total errors found: 4 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 247060 [details] Patch v3 (in-progress; checking EWS)
Attachment 247060 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:50: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:50: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:48: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:49: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:54: Bad include order. Mixing system and custom headers. [build/include_order] [4] Total errors found: 5 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 247061 [details] Patch v4 (in-progress; checking EWS)
Attachment 247061 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:50: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:50: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:48: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:49: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:54: Bad include order. Mixing system and custom headers. [build/include_order] [4] Total errors found: 5 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 247062 [details] Patch v5 (in-progress; checking EWS)
Attachment 247062 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:50: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:50: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:48: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:49: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:54: Bad include order. Mixing system and custom headers. [build/include_order] [4] Total errors found: 5 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 247063 [details] Patch v6 (in-progress; checking EWS)
Attachment 247063 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:50: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:50: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:48: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:49: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:54: Bad include order. Mixing system and custom headers. [build/include_order] [4] Total errors found: 5 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 247064 [details] Patch v7 (in-progress; checking EWS)
Attachment 247064 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:50: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:50: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:48: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:49: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:54: Bad include order. Mixing system and custom headers. [build/include_order] [4] Total errors found: 5 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 247065 [details] Patch v8 (in-progress; checking EWS)
Attachment 247065 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:50: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:50: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:48: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:49: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:54: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:58: Bad include order. Mixing system and custom headers. [build/include_order] [4] Total errors found: 6 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 247066 [details] Patch v9 (in-progress; checking EWS)
Attachment 247066 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:50: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:50: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:48: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:49: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:54: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:58: Bad include order. Mixing system and custom headers. [build/include_order] [4] Total errors found: 6 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 247067 [details] Patch v10 (in-progress; checking EWS)
Attachment 247067 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:50: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:50: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:48: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:49: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:54: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:58: Bad include order. Mixing system and custom headers. [build/include_order] [4] Total errors found: 6 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #20) > Attachment 247067 [details] did not pass style-queue: > > > ERROR: > Source/WebCore/platform/graphics/avfoundation/objc/ > MediaPlayerPrivateMediaSourceAVFObjC.mm:50: Bad include order. Mixing > system and custom headers. [build/include_order] [4] > ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:50: > Bad include order. Mixing system and custom headers. [build/include_order] > [4] > ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:48: > Bad include order. Mixing system and custom headers. [build/include_order] > [4] > ERROR: > Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp: > 49: Bad include order. Mixing system and custom headers. > [build/include_order] [4] > ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:54: Bad > include order. Mixing system and custom headers. [build/include_order] [4] > ERROR: > Source/WebCore/platform/graphics/avfoundation/objc/ > SourceBufferPrivateAVFObjC.mm:58: Bad include order. Mixing system and > custom headers. [build/include_order] [4] > Total errors found: 6 in 14 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. Bug 141872 covers fixing these warning messages.
Created attachment 247076 [details] Patch v11 (in-progress; checking EWS)
Attachment 247076 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:50: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:48: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:49: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:54: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:58: Bad include order. Mixing system and custom headers. [build/include_order] [4] Total errors found: 5 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 247077 [details] Patch v12 (in-progress; checking EWS)
Attachment 247077 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:50: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:48: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:49: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:54: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:58: Bad include order. Mixing system and custom headers. [build/include_order] [4] Total errors found: 5 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 247078 [details] Patch v13 (in-progress; checking EWS)
Attachment 247078 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:50: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:48: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:49: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:54: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:58: Bad include order. Mixing system and custom headers. [build/include_order] [4] Total errors found: 5 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 247079 [details] Patch v14 (in-progress; checking EWS)
Attachment 247079 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:50: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:48: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:49: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:54: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:58: Bad include order. Mixing system and custom headers. [build/include_order] [4] Total errors found: 5 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 247081 [details] Patch v15 (in-progress; checking EWS)
Attachment 247081 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:50: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:48: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:49: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:54: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:58: Bad include order. Mixing system and custom headers. [build/include_order] [4] Total errors found: 5 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 247081 [details] Patch v15 (in-progress; checking EWS) View in context: https://bugs.webkit.org/attachment.cgi?id=247081&action=review > Source/WebCore/ChangeLog:8 > + FIXME: Write ChangeLog once all changes are done. Should do that.
Created attachment 247739 [details] Patch v16 (final)
Attachment 247739 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:50: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/AVMediaCaptureSource.mm:43: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:42: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:49: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/mac/PlatformClockCM.mm:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:54: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:58: Bad include order. Mixing system and custom headers. [build/include_order] [4] Total errors found: 7 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #34) > Attachment 247739 [details] did not pass style-queue: > > > ERROR: > Source/WebCore/platform/graphics/avfoundation/objc/ > MediaPlayerPrivateMediaSourceAVFObjC.mm:50: Bad include order. Mixing > system and custom headers. [build/include_order] [4] > ERROR: Source/WebCore/platform/mediastream/mac/AVMediaCaptureSource.mm:43: > Bad include order. Mixing system and custom headers. [build/include_order] > [4] > ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:42: > Bad include order. Mixing system and custom headers. [build/include_order] > [4] > ERROR: > Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp: > 49: Bad include order. Mixing system and custom headers. > [build/include_order] [4] > ERROR: Source/WebCore/platform/mac/PlatformClockCM.mm:34: Alphabetical > sorting problem. [build/include_order] [4] > ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:54: Bad > include order. Mixing system and custom headers. [build/include_order] [4] > ERROR: > Source/WebCore/platform/graphics/avfoundation/objc/ > SourceBufferPrivateAVFObjC.mm:58: Bad include order. Mixing system and > custom headers. [build/include_order] [4] > Total errors found: 7 in 15 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. Patch on Bug 141872 fixes these new false-positive style errors.
Comment on attachment 247739 [details] Patch v16 (final) View in context: https://bugs.webkit.org/attachment.cgi?id=247739&action=review > Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:53 > +// Soft-linking headers must be included last since they #define functions, constants, etc. Will all these comments be necessary after your style change? I'd be ok if you left them out.
(In reply to comment #36) > Comment on attachment 247739 [details] > Patch v16 (final) > > View in context: > https://bugs.webkit.org/attachment.cgi?id=247739&action=review > > > Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:53 > > +// Soft-linking headers must be included last since they #define functions, constants, etc. > > Will all these comments be necessary after your style change? I'd be ok if > you left them out. Great point. Now that Bug 141872 enforces the style checking, they're probably unnecessary. Will remove before landing.
Created attachment 247889 [details] Patch for landing
Comment on attachment 247889 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=247889&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:47 > -#pragma mark - > -#pragma mark Soft Linking > +#pragma mark - Soft Linking I think this change should not be made. Leave one line - and one line Soft Linking
(In reply to comment #39) > Comment on attachment 247889 [details] > Patch for landing > > View in context: > https://bugs.webkit.org/attachment.cgi?id=247889&action=review > > > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:47 > > -#pragma mark - > > -#pragma mark Soft Linking > > +#pragma mark - Soft Linking > > I think this change should not be made. Leave one line - and one line Soft > Linking Why? You get the exact same rendering in Xcode.
Comment on attachment 247889 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=247889&action=review >>> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:47 >>> +#pragma mark - Soft Linking >> >> I think this change should not be made. Leave one line - and one line Soft Linking > > Why? You get the exact same rendering in Xcode. Ok. No big deal. In it goes!
Comment on attachment 247889 [details] Patch for landing Clearing flags on attachment: 247889 Committed r181036: <http://trac.webkit.org/changeset/181036>
Moving to RESOLVED/FIXED. Not sure why the commit bot didn't do that.
(In reply to comment #42) > Comment on attachment 247889 [details] > Patch for landing > > Clearing flags on attachment: 247889 > > Committed r181036: <http://trac.webkit.org/changeset/181036> Follow-up build fix: Committed r181049: < http://trac.webkit.org/changeset/181049>
(In reply to comment #44) > (In reply to comment #42) > > Comment on attachment 247889 [details] > > Patch for landing > > > > Clearing flags on attachment: 247889 > > > > Committed r181036: <http://trac.webkit.org/changeset/181036> > > Follow-up build fix: > Committed r181049: < http://trac.webkit.org/changeset/181049> Follow-up Windows build fix: Committed r181055: <http://trac.webkit.org/changeset/181055>