Bug 142177 – Rename SOFT_LINK_{CONSTANT,FUNCTION}_{HEADER,SOURCE} to SOFT_LINK_{CONSTANT,FUNCTION}_FOR_{HEADER,SOURCE}

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[David Kilzer (:ddkilzer)]

In Bug 141816 Comment #17, Alexey suggests renaming the SOFT_LINK macros to include a preposition so they're more readable.

After leaving this code for a few days and coming back, I'm inclined to agree:

SOFT_LINK_{CONSTANT,FUNCTION}_HEADER() => SOFT_LINK_{CONSTANT,FUNCTION}_FOR_HEADER()
SOFT_LINK_{CONSTANT,FUNCTION}_SOURCE() => SOFT_LINK_{CONSTANT,FUNCTION}_FOR_SOURCE()

In bug 141816, Alexey suggested "CPP" instead of "SOURCE", although I find "CPP" more ambiguous:  "C Pre-Processor", which would be the same as "HEADER" vs. "C-Plus-Plus [Source]".

I suppose if we used "CPP" instead of "SOURCE", we should use "H" instead of "HEADER" to be consistent, but that doesn't seem like an improvement either.

Will follow up with Alexey in person.

[David Kilzer (:ddkilzer)]

Created attachment 247925 [details]
Patch v1

[David Kilzer (:ddkilzer)]

(In reply to comment #0)
> Will follow up with Alexey in person.

Oops, didn't do this yet.  Review may have to wait.

[Alex Christensen]

Comment on attachment 247925 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=247925&action=review

> Source/WebCore/ChangeLog:1
>  2015-03-04  David Kilzer  <[e-mail]>

The commit queue won't like that your name is at the bottom.  Land this manually.

[Alex Christensen]

I like it as-is, but talk to Alexey in person before landing.

[David Kilzer (:ddkilzer)]

(In reply to comment #3)
> Comment on attachment 247925 [details]
> Patch v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=247925&action=review
> 
> > Source/WebCore/ChangeLog:1
> >  2015-03-04  David Kilzer  <[e-mail]>
> 
> The commit queue won't like that your name is at the bottom.  Land this
> manually.

We need a bug about this if the commit queue fails on a patch like this.  It should apply cleanly as I wrote the code in svn-apply that fixes this up!

<http://trac.webkit.org/browser/trunk/Tools/Scripts/VCSUtils.pm?annotate=blame#L1583>

[David Kilzer (:ddkilzer)]

(In reply to comment #5)
> (In reply to comment #3)
> > Comment on attachment 247925 [details]
> > Patch v1
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=247925&action=review
> > 
> > > Source/WebCore/ChangeLog:1
> > >  2015-03-04  David Kilzer  <[e-mail]>
> > 
> > The commit queue won't like that your name is at the bottom.  Land this
> > manually.
> 
> We need a bug about this if the commit queue fails on a patch like this.  It
> should apply cleanly as I wrote the code in svn-apply that fixes this up!
> 
> <http://trac.webkit.org/browser/trunk/Tools/Scripts/VCSUtils.
> pm?annotate=blame#L1583>

Original commit:  <http://trac.webkit.org/changeset/15393>

[WebKit Commit Bot]

Comment on attachment 247925 [details]
Patch v1

Clearing flags on attachment: 247925

Committed r181142: <http://trac.webkit.org/changeset/181142>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.