WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
127640
Subpixel Layout: Align <input type="button", submit etc (PushButtonPart) top and bottom paddings with <button>
https://bugs.webkit.org/show_bug.cgi?id=127640
Summary
Subpixel Layout: Align <input type="button", submit etc (PushButtonPart) top ...
zalan
Reported
2014-01-25 20:53:39 PST
<button> sets padding-top: 2px and padding-bottom: 3px by default while <input type="button" sets it to 0, 0 and we center the text using the available space. This results in different baseline text position in same cases.
Attachments
Patch
(1.02 MB, patch)
2014-01-25 21:04 PST
,
zalan
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion
(591.07 KB, application/zip)
2014-01-25 22:16 PST
,
Build Bot
no flags
Details
Patch
(1.07 MB, patch)
2014-01-25 22:34 PST
,
zalan
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2
(1.15 MB, application/zip)
2014-01-25 23:33 PST
,
Build Bot
no flags
Details
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion
(1.14 MB, application/zip)
2014-01-25 23:51 PST
,
Build Bot
no flags
Details
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion
(1.16 MB, application/zip)
2014-01-26 01:51 PST
,
Build Bot
no flags
Details
Patch
(1.08 MB, patch)
2014-01-26 08:46 PST
,
zalan
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
zalan
Comment 1
2014-01-25 21:04:07 PST
Created
attachment 222249
[details]
Patch
zalan
Comment 2
2014-01-25 21:04:43 PST
Comment on
attachment 222249
[details]
Patch EWS testing for MountainLion.
Build Bot
Comment 3
2014-01-25 22:16:22 PST
Comment on
attachment 222249
[details]
Patch
Attachment 222249
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.appspot.com/results/6515840526581760
New failing tests: fast/forms/button-sizes.html fast/overflow/scroll-nested-positioned-layer-in-overflow.html fast/forms/control-restrict-line-height.html tables/mozilla/bugs/bug2479-3.html tables/mozilla/bugs/bug2479-2.html fast/forms/button-style-color.html editing/selection/3690719.html fast/replaced/replaced-breaking.html fast/forms/input-button-sizes.html fast/css/margin-top-bottom-dynamic.html fast/forms/button-table-styles.html tables/mozilla/bugs/bug1188.html fast/forms/validation-message-appearance.html http/tests/navigation/javascriptlink-frames.html tables/mozilla/collapsing_borders/
bug41262
-4.html fast/html/details-replace-summary-child.html fast/css/continuationCrash.html fast/text/textIteratorNilRenderer.html editing/selection/3690703-2.html fast/forms/file/input-file-re-render.html fast/forms/input-value.html fast/forms/input-appearance-height.html fast/forms/button-text-transform.html tables/mozilla/bugs/bug2479-4.html fast/forms/button-positioned.html editing/selection/3690703.html fast/forms/form-element-geometry.html fast/html/details-replace-text.html fast/dom/HTMLTextAreaElement/reset-textarea.html fast/forms/box-shadow-override.html
Build Bot
Comment 4
2014-01-25 22:16:24 PST
Created
attachment 222253
[details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5
zalan
Comment 5
2014-01-25 22:34:40 PST
Created
attachment 222254
[details]
Patch
zalan
Comment 6
2014-01-25 22:35:04 PST
Comment on
attachment 222254
[details]
Patch EWS
Build Bot
Comment 7
2014-01-25 23:33:08 PST
Comment on
attachment 222254
[details]
Patch
Attachment 222254
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.appspot.com/results/5612379324809216
New failing tests: tables/mozilla/bugs/
bug28928
.html tables/mozilla/bugs/
bug46368
-2.html tables/mozilla/bugs/
bug33855
.html tables/mozilla/bugs/
bug26178
.html tables/mozilla/bugs/
bug51037
.html tables/mozilla/bugs/
bug51727
.html tables/mozilla/dom/tableDom.html tables/mozilla_expected_failures/bugs/
bug58402
-2.html tables/mozilla/bugs/
bug46368
-1.html tables/mozilla/bugs/
bug138725
.html tables/mozilla/other/move_row.html tables/mozilla/bugs/
bug18359
.html tables/mozilla/bugs/
bug7342
.html tables/mozilla/bugs/
bug52505
.html tables/mozilla_expected_failures/bugs/bug2479-5.html
Build Bot
Comment 8
2014-01-25 23:33:10 PST
Created
attachment 222262
[details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Build Bot
Comment 9
2014-01-25 23:51:00 PST
Comment on
attachment 222254
[details]
Patch
Attachment 222254
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.appspot.com/results/5359634994954240
New failing tests: tables/mozilla/bugs/
bug28928
.html tables/mozilla/bugs/
bug46368
-2.html tables/mozilla/bugs/
bug33855
.html tables/mozilla/bugs/
bug26178
.html tables/mozilla/bugs/
bug51037
.html tables/mozilla/bugs/
bug51727
.html tables/mozilla/dom/tableDom.html tables/mozilla_expected_failures/bugs/
bug58402
-2.html tables/mozilla/bugs/
bug46368
-1.html tables/mozilla/bugs/
bug138725
.html tables/mozilla/other/move_row.html tables/mozilla/bugs/
bug18359
.html tables/mozilla/bugs/
bug7342
.html tables/mozilla/bugs/
bug52505
.html tables/mozilla_expected_failures/bugs/bug2479-5.html
Build Bot
Comment 10
2014-01-25 23:51:02 PST
Created
attachment 222263
[details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Build Bot
Comment 11
2014-01-26 01:51:25 PST
Comment on
attachment 222254
[details]
Patch
Attachment 222254
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.appspot.com/results/4988326817824768
New failing tests: tables/mozilla/bugs/
bug28928
.html tables/mozilla/bugs/
bug46368
-2.html tables/mozilla/bugs/
bug33855
.html tables/mozilla/bugs/
bug26178
.html tables/mozilla/bugs/
bug51037
.html tables/mozilla/bugs/
bug51727
.html tables/mozilla/dom/tableDom.html tables/mozilla_expected_failures/bugs/
bug58402
-2.html tables/mozilla/bugs/
bug46368
-1.html tables/mozilla/bugs/
bug138725
.html tables/mozilla/other/move_row.html tables/mozilla/bugs/
bug18359
.html tables/mozilla/bugs/
bug7342
.html tables/mozilla/bugs/
bug52505
.html tables/mozilla_expected_failures/bugs/bug2479-5.html
Build Bot
Comment 12
2014-01-26 01:51:28 PST
Created
attachment 222266
[details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.5
zalan
Comment 13
2014-01-26 08:46:09 PST
Created
attachment 222274
[details]
Patch
zalan
Comment 14
2014-01-26 08:46:30 PST
Comment on
attachment 222274
[details]
Patch EWSing
WebKit Commit Bot
Comment 15
2014-01-26 10:24:03 PST
Comment on
attachment 222274
[details]
Patch Clearing flags on attachment: 222274 Committed
r162803
: <
http://trac.webkit.org/changeset/162803
>
WebKit Commit Bot
Comment 16
2014-01-26 10:24:08 PST
All reviewed patches have been landed. Closing bug.
Jon Lee
Comment 17
2014-01-28 09:58:10 PST
***
Bug 101848
has been marked as a duplicate of this bug. ***
Jon Lee
Comment 18
2014-01-28 09:59:00 PST
<
rdar://problem/12678254
>
Radar WebKit Bug Importer
Comment 19
2014-01-28 09:59:27 PST
<
rdar://problem/15926052
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug