Bug 52505 - [jsfunfuzz] Incorrect handling of consecutive duplicate labels
Summary: [jsfunfuzz] Incorrect handling of consecutive duplicate labels
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 13638
  Show dependency treegraph
 
Reported: 2011-01-14 19:03 PST by Oliver Hunt
Modified: 2011-01-14 22:35 PST (History)
3 users (show)

See Also:


Attachments
Patch (3.97 KB, patch)
2011-01-14 22:00 PST, Oliver Hunt
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2011-01-14 19:03:07 PST
When I reworked label handling I incorrectly compared Identifier*'s rather than their impls.  This caused the following test to assert:

tryItOut("\"\";L:L:if(s);else if(\"\")\"\"")
Comment 1 Oliver Hunt 2011-01-14 19:07:49 PST
I've fixed this but my tree just picked up a "rebuild the world" patch so it's going to take a while to get the testcase verified.
Comment 2 Oliver Hunt 2011-01-14 22:00:05 PST
Created attachment 79052 [details]
Patch
Comment 3 Maciej Stachowiak 2011-01-14 22:07:45 PST
Comment on attachment 79052 [details]
Patch

r=me
Comment 4 Oliver Hunt 2011-01-14 22:35:42 PST
Committed r75872: <http://trac.webkit.org/changeset/75872>