Bug 46368 - It should be possible to conditionally define an entire group of messages
Summary: It should be possible to conditionally define an entire group of messages
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-23 10:14 PDT by Anders Carlsson
Modified: 2010-09-23 10:28 PDT (History)
0 users

See Also:

Attachments
Patch (5.08 KB, patch)
2010-09-23 10:15 PDT, Anders Carlsson 		aroben: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-09-23 10:14:22 PDT 
It should be possible to conditionally define an entire group of messages
Comment 1 Anders Carlsson 2010-09-23 10:15:23 PDT 
Created attachment 68539 [details]
Patch
Comment 2 Adam Roben (:aroben) 2010-09-23 10:23:02 PDT 
Comment on attachment 68539 [details]
Patch

You should test that the condition makes it into the output files, too, not just that we parse it correctly. ReceiverImplementationTest already does some things like that.
Comment 3 Anders Carlsson 2010-09-23 10:28:01 PDT 
Committed r68159: <http://trac.webkit.org/changeset/68159>