Summary: | [Form] Multiple fields time input UI | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | yosin | ||||||||||||||
Component: | Forms | Assignee: | yosin | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | cmarcelo, dglazkov, donggwan.kim, haizhang, macpherson, menard, mifenton, tkent, webkit.review.bot | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
URL: | http://jsfiddle.net/zR3uW/ | ||||||||||||||||
Bug Depends on: | 96035, 89425, 89439, 89963, 89965, 90036, 90236, 90956, 92230, 92339, 92822, 92834, 92960, 93929, 94166, 94195, 96032 | ||||||||||||||||
Bug Blocks: | 86990 | ||||||||||||||||
Attachments: |
|
Description
yosin
2012-06-13 00:16:18 PDT
Created attachment 147250 [details]
Patch 1 - WIP
Created attachment 147253 [details]
Patch 2 - WIP
Created attachment 149269 [details]
Patch 3 - Code Complete
Created attachment 149496 [details]
Patch 4 - Code Complete
Because you'll add new ENABLE flag, you had better announce it and your plan to webkit-dev. Created attachment 151641 [details]
Patch 5 - Code Complete
Created attachment 155459 [details]
Patch 6
Comment on attachment 155459 [details]
Patch 6
Could you review this patch?
Tests will be uploaded into another bug for reducing size of patch.
ChangeLogs isn't incomplete.
Thanks in advance.
Comment on attachment 155459 [details] Patch 6 Attachment 155459 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13385816 Comment on attachment 155459 [details] Patch 6 View in context: https://bugs.webkit.org/attachment.cgi?id=155459&action=review Ok, I agree with the design and the rough structure. Let's split this into multiple patches like: 1. Enable ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS and touch source files with ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS) (Only DateTimeFormat.h?) 2. WebCore/css/html.css part 3. WebCore/html/shadow/ part 4. WebCore/html/ part 5. RuntimeEnabledFeatures.cpp part > Source/WebCore/html/shadow/DateTimeFieldElements.h:88 > +class DateTimeNumericFieldElement : public DateTimeFieldElement { Please make its own source files. This class is not small. > Source/WebCore/html/shadow/DateTimeFieldElements.h:136 > +class DateTimeHourFieldElement : public DateTimeNumericFieldElement { ditto. > Source/WebCore/html/shadow/DateTimeFieldElements.h:153 > +class DateTimeSymbolicFieldElement : public DateTimeFieldElement { ditto. Multiple fields time input UI is enabled for Chromium port, except for Android: http://trac.webkit.org/changeset/125868 |