Bug 65787

Summary:	Add missing tests for LegacyDefaultOptionalArgument removal
Product:	WebKit	Reporter:	Adam Barth <abarth>
Component:	WebCore JavaScript	Assignee:	Nobody <webkit-unassigned>
Status:	NEW ---
Severity:	Normal	CC:	donggwan.kim, pilgrim, sam
Priority:	P2
Version:	528+ (Nightly build)
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:	65802, 65810, 65812, 65814, 65815, 65816, 66234, 66235, 66236
Bug Blocks:

Description Adam Barth 2011-08-05 13:07:40 PDT

Looks like these patches have some behavior changes without tests.

https://bugs.webkit.org/show_bug.cgi?id=64539
https://bugs.webkit.org/show_bug.cgi?id=65338
https://bugs.webkit.org/show_bug.cgi?id=65353
https://bugs.webkit.org/show_bug.cgi?id=65355

Geolocation.clearWatch()
PositionCallback.handleEvent()
PositionErrorCallback.handleEvent()

https://bugs.webkit.org/show_bug.cgi?id=65570

SpeechInputResultList.item()

https://bugs.webkit.org/show_bug.cgi?id=65571

WebKitAnimationList.item()

https://bugs.webkit.org/show_bug.cgi?id=65715

MediaStreamList.item()
MediaStreamTrackList.item()
TouchList.item()

https://bugs.webkit.org/show_bug.cgi?id=65750

AudioBufferSourceNode.noteOn()
AudioBufferSourceNode.noteGrainOn()
AudioBufferSourceNode.noteOff()

We should add tests for the changed behavior.

Comment 1 Sam Weinig 2011-08-05 17:39:07 PDT

This doesn't seem to include the changes to addEventListener/removeEventListener.  Are those covered elsewhere?

Comment 2 Adam Barth 2011-08-05 17:46:08 PDT

> Are those covered elsewhere?

Filed as blocking this bug.

Comment 3 Adam Barth 2011-08-06 12:35:45 PDT

> MediaStreamList.item()
> MediaStreamTrackList.item()

As far as I can tell, the PeerConnection API isn't far enough along to test this IDL change.  I don't see any tests that even instantiate the PeerConnection object.  It seems like the compat impact from this change is non-existent, so matching the spec is the best course of action.