Bug 65355 - Remove LegacyDefaultOptionalArguments flag from geolocation IDL files
Summary: Remove LegacyDefaultOptionalArguments flag from geolocation IDL files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-28 19:36 PDT by Mark Pilgrim (Google)
Modified: 2011-08-03 16:02 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.93 KB, patch)
2011-07-28 19:40 PDT, Mark Pilgrim (Google) 		no flags Details | Formatted Diff | Diff
Patch (2.93 KB, patch)
2011-08-03 14:43 PDT, Mark Pilgrim (Google) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2011-07-28 19:36:18 PDT 
As discussed in IRC, we are migrating our IDL files away from the interface-level "LegacyDefaultOptionalArguments" flag and onto argument-level [Optional] or [Optional=CallWithDefaultValue] flags. This patch migrates geolocation-related files. This patch changes behavior -- it makes the geolocation methods match the spec for which arguments are required and which are optional, and (newly) throw TypeError if required arguments are missing.
Comment 1 Mark Pilgrim (Google) 2011-07-28 19:40:24 PDT 
Created attachment 102326 [details]
Patch
Comment 2 Adam Barth 2011-07-28 22:45:02 PDT 
Comment on attachment 102326 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102326&action=review

> Source/WebCore/page/PositionErrorCallback.idl:-28
> -        LegacyDefaultOptionalArguments,

We can probably nuke this attribute on all Callback=FunctionOnly interfaces.
Comment 3 Adam Barth 2011-08-02 13:48:31 PDT 
Comment on attachment 102326 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102326&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

Actually, this line will cause the commit-queue to bounce your patch.
Comment 4 Mark Pilgrim (Google) 2011-08-03 14:43:21 PDT 
Created attachment 102830 [details]
Patch
Comment 5 WebKit Review Bot 2011-08-03 16:01:58 PDT 
Comment on attachment 102830 [details]
Patch

Clearing flags on attachment: 102830

Committed r92323: <http://trac.webkit.org/changeset/92323>
Comment 6 WebKit Review Bot 2011-08-03 16:02:02 PDT 
All reviewed patches have been landed.  Closing bug.