Bug 66236 - Add missing tests for LegacyDefaultOptionalArguments/FileAPI IDL
Summary: Add missing tests for LegacyDefaultOptionalArguments/FileAPI IDL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 65787
  Show dependency tree / graph
 
Reported: 2011-08-15 09:34 PDT by Adam Barth
Modified: 2011-10-07 10:20 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.70 KB, patch)
2011-10-06 19:51 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (6.46 KB, patch)
2011-10-07 08:55 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-08-15 09:34:36 PDT 
Many FileAPI-related functions changed.

See https://bugs.webkit.org/show_bug.cgi?id=64539 for the IDL change.
Comment 1 Adam Barth 2011-10-06 10:01:42 PDT 
These are the APIs that appear to have changed:

DirectoryReader.readEntries
Entry.moveTo
Entry.copyTo
EntryArray.item
EntryArraySync.item
EntrySync.moveTo
EntrySync.copyTo
FileEntry.createWriter
FileEntry.file
FileList.item
FileReader.readAsArrayBuffer
FileReader.readAsBinaryString
FileReader.readAsText
FileReader.readAsDataURL
FileReaderSync.readAsArrayBuffer
FileReaderSync.readAsBinaryString
FileReaderSync.readAsText
FileReaderSync.readAsDataURL
FileWriter.write
FileWriter.seek
FileWriter.truncate
FileWriterSync.write
FileWriterSync.seek
FileWriterSync.truncate
WebKitBlobBuilder.append
Comment 2 Adam Barth 2011-10-06 19:51:39 PDT 
Created attachment 110081 [details]
Patch
Comment 3 WebKit Review Bot 2011-10-06 20:55:43 PDT 
Comment on attachment 110081 [details]
Patch

Attachment 110081 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10010075

New failing tests:
fast/files/not-enough-arguments.html
Comment 4 Adam Barth 2011-10-06 22:10:59 PDT 
Comment on attachment 110081 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=110081&action=review

> LayoutTests/fast/files/not-enough-arguments-expected.txt:17
> +#EOF

Oops.  This is raw DRT output.  :)
Comment 5 Adam Barth 2011-10-07 08:55:52 PDT 
Created attachment 110153 [details]
Patch
Comment 6 WebKit Review Bot 2011-10-07 10:20:02 PDT 
Comment on attachment 110153 [details]
Patch

Clearing flags on attachment: 110153

Committed r96956: <http://trac.webkit.org/changeset/96956>
Comment 7 WebKit Review Bot 2011-10-07 10:20:07 PDT 
All reviewed patches have been landed.  Closing bug.