Bug 64539 - Remove LegacyDefaultOptionalArguments flag from FileAPI
Summary: Remove LegacyDefaultOptionalArguments flag from FileAPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-14 10:32 PDT by Mark Pilgrim (Google)
Modified: 2011-07-21 12:14 PDT (History)
5 users (show)

See Also:


Attachments
Patch (10.58 KB, patch)
2011-07-14 10:34 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2011-07-14 10:32:47 PDT
As per discussion in IRC, we are tightening up the semantics of APIs, starting with the newer APIs and working backwards. This change will make "required" arguments actually required across the File API.
Comment 1 Mark Pilgrim (Google) 2011-07-14 10:34:17 PDT
Created attachment 100826 [details]
Patch
Comment 2 Adam Barth 2011-07-14 18:45:09 PDT
Comment on attachment 100826 [details]
Patch

I've added some folks who work on the File API to make this this patch is fine with them.  Please give them some time to respond to the bug before landing.
Comment 3 Adam Klein 2011-07-15 15:58:07 PDT
This looks right to me (especially if the tests pass), but Kinuko probably has a bit more context on the WebKit side of things than Eric, so adding her too.
Comment 4 Kinuko Yasuda 2011-07-18 22:40:04 PDT
This looks good to me, but is it really ok/agreed to make them "required" while the spec still say they are optional?  (Just asking)
Comment 5 Adam Barth 2011-07-19 00:31:14 PDT
(In reply to comment #4)
> This looks good to me, but is it really ok/agreed to make them "required" while the spec still say they are optional?  (Just asking)

Does the spec say that they're optional?
Comment 6 Kinuko Yasuda 2011-07-19 01:02:21 PDT
Sorry I was mistaken; this change makes "required" arguments required-- sounds good then!
Comment 7 Adam Barth 2011-07-19 01:07:39 PDT
Comment on attachment 100826 [details]
Patch

Thanks!
Comment 8 Mark Pilgrim (Google) 2011-07-21 10:41:29 PDT
Adam, can you please land this patch now?
Comment 9 WebKit Review Bot 2011-07-21 12:14:00 PDT
Comment on attachment 100826 [details]
Patch

Clearing flags on attachment: 100826

Committed r91486: <http://trac.webkit.org/changeset/91486>
Comment 10 WebKit Review Bot 2011-07-21 12:14:05 PDT
All reviewed patches have been landed.  Closing bug.