As per discussion in IRC, we are tightening up the semantics of APIs, starting with the newer APIs and working backwards. This change will make "required" arguments actually required across the File API.
Created attachment 100826 [details] Patch
Comment on attachment 100826 [details] Patch I've added some folks who work on the File API to make this this patch is fine with them. Please give them some time to respond to the bug before landing.
This looks right to me (especially if the tests pass), but Kinuko probably has a bit more context on the WebKit side of things than Eric, so adding her too.
This looks good to me, but is it really ok/agreed to make them "required" while the spec still say they are optional? (Just asking)
(In reply to comment #4) > This looks good to me, but is it really ok/agreed to make them "required" while the spec still say they are optional? (Just asking) Does the spec say that they're optional?
Sorry I was mistaken; this change makes "required" arguments required-- sounds good then!
Comment on attachment 100826 [details] Patch Thanks!
Adam, can you please land this patch now?
Comment on attachment 100826 [details] Patch Clearing flags on attachment: 100826 Committed r91486: <http://trac.webkit.org/changeset/91486>
All reviewed patches have been landed. Closing bug.