Bug 65812 - Test how SpeechInputResultList behaves with not enough arguments
Summary: Test how SpeechInputResultList behaves with not enough arguments
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 65787
  Show dependency tree / graph
 
Reported: 2011-08-06 12:12 PDT by Adam Barth
Modified: 2011-08-11 01:11 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.31 KB, patch)
2011-08-06 12:15 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (3.43 KB, patch)
2011-08-08 12:42 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-08-06 12:12:24 PDT 
Test how SpeechInputResultList behaves with not enough arguments
Comment 1 Adam Barth 2011-08-06 12:15:10 PDT 
Created attachment 103154 [details]
Patch
Comment 2 Adam Barth 2011-08-06 12:15:50 PDT 
I don't have a build with speech enabled, but hopefully the cr-linux-ews will provide me with the expected.txt file.
Comment 3 WebKit Review Bot 2011-08-07 13:13:03 PDT 
Comment on attachment 103154 [details]
Patch

Attachment 103154 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9329547

New failing tests:
fast/speech/speech-input-result-list-not-enough-arguments.html
Comment 4 Adam Barth 2011-08-08 12:42:44 PDT 
Created attachment 103277 [details]
Patch
Comment 5 Sam Weinig 2011-08-10 19:53:34 PDT 
Comment on attachment 103277 [details]
Patch

Does this need to be added to some skipped lists, or is the speech directory already in them?
Comment 6 Adam Barth 2011-08-10 20:52:52 PDT 
> Does this need to be added to some skipped lists, or is the speech directory already in them?

Good question.  I believe the directory is skipped, but I will check before landing.
Comment 7 Adam Barth 2011-08-11 00:09:43 PDT 
Comment on attachment 103277 [details]
Patch

Verified for Mac, Win, GTK, and Qt.
Comment 8 WebKit Review Bot 2011-08-11 01:11:01 PDT 
Comment on attachment 103277 [details]
Patch

Clearing flags on attachment: 103277

Committed r92828: <http://trac.webkit.org/changeset/92828>
Comment 9 WebKit Review Bot 2011-08-11 01:11:06 PDT 
All reviewed patches have been landed.  Closing bug.