Bug 65816 – Test how AudioBufferSourceNode reacts when given too few arguments

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

Test how AudioBufferSourceNode reacts when given too few arguments

[Adam Barth]

Created attachment 103158 [details]
Patch

[WebKit Review Bot]

Comment on attachment 103158 [details]
Patch

Attachment 103158 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9329944

New failing tests:
webaudio/audionode.html

[Adam Barth]

Created attachment 103282 [details]
Patch

[Chris Rogers]

Hi Adam, thanks for the patch.

This seems fine to me.  I few of my demos were passing in no argument to noteOn(), which I was intending to support (meaning "play now").  But, thinking about this a bit more, I think it's a good idea for people to think about these APIs (especially noteOn()) as they relate to time.  So, the time value should always be explicit (even if 0 is passed in which means "play now").

[Adam Barth]

Chris, it's entirely up to you.  I'm happy to mark the arguments as optional if that's what you'd prefer.

[Chris Rogers]

Hi Adam, I think the requirement for the argument is fine.  I've already updated my two samples with the change.  The specification doesn't mark the argument as optional, and I don't think there are any significant demos other people have done which this will break.

In general, though, I'd always appreciate a "heads-up" for any (potentially breaking) API change.

[Adam Barth]

> In general, though, I'd always appreciate a "heads-up" for any (potentially breaking) API change.

Definitely.  There was some miscommunication.  I thought you had already signed off.

[WebKit Review Bot]

Comment on attachment 103282 [details]
Patch

Clearing flags on attachment: 103282

Committed r92817: <http://trac.webkit.org/changeset/92817>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.