|Summary:||[Qt] Qt bridge bindings should be rewritten using JSC API|
|Product:||WebKit||Reporter:||Oliver Hunt <oliver>|
|Component:||WebKit Qt||Assignee:||Simon Hausmann <hausmann>|
|Severity:||Major||CC:||agbakken, allan.jensen, ararunprasad, arurajku, cmarcelo, cshu, girish, hausmann, kent.hansen, lars.knoll, laszlo.gombos, loki, luiz, noam, oliver, ossy, pvarga, yael, zherczeg|
|Version:||528+ (Nightly build)|
|Bug Depends on:||62330, 88161, 93462, 93463, 93476, 93649, 93716, 93720, 93868, 93872, 93880, 93889, 93897, 94695, 94702, 95325, 95570|
Description Oliver Hunt 2011-05-14 12:46:13 PDT
The Qt bridge bindings are a frequent source of pain and frustration for those of us working on the actual engine as they aren't obviously maintained and no one seems to claim any real ownership of them. For this reason they should be rewritten using the JSC API and so be protected from underlying changes in JSC.
Comment 1 Noam Rosenthal 2011-05-15 07:46:02 PDT
I'm trying to see how feasible it is and what we'd need to change in the API. So far it seems the main missing part is being able to access internal types that are known to WebCore, like ByteArray or HTMLElement.
Comment 2 Zoltan Herczeg 2011-05-16 02:32:45 PDT
I have already fixed several bugs in the bridge/qt, and in my experience the changes in the GC mechanism affects badly this code, like all the others in the bridge directory. I am thinking now what could be done here.
Comment 3 Noam Rosenthal 2011-05-22 23:50:25 PDT
*** Bug 39746 has been marked as a duplicate of this bug. ***
Comment 4 Noam Rosenthal 2011-05-23 00:47:33 PDT
Created attachment 94377 [details] WIP patch This patch still needs lots of work, but it covers the basics. Still doesn't work: 1. __qt_sender__ (the code is there, but crashes...) 2. ScriptOwnership 3. deleting properties It also doesn't pass the style tests and other things but I wanted people to see where things stand.
Comment 5 Oliver Hunt 2011-05-23 08:55:21 PDT
Comment 6 Noam Rosenthal 2011-05-23 11:00:51 PDT
Why are you spending your time reviewing this? I haven't put an r? on it and made clear that this is WIP and needs a lot of more work. I've put it up so that people can track what's being done. For now it includes some API changes that of course I'd review separately.
Comment 7 Simon Hausmann 2012-08-02 04:54:36 PDT
I'm working on this and am maintaining a work-in-progress patch set at https://github.com/tronical/webkit/commits/jsc-runtime . I'll create sub-tasks once I'm ready for inclusion to trunk. I'm doing the changes only for the Qt 5 code path, so I'm making this bug depend on bug #88161
Comment 8 Allan Sandfeld Jensen 2014-02-03 02:32:39 PST
Mostly fixed, out of scope anyway.