[Qt] JSC Bridge: convert QtConnectionObject to use JSC API
Created attachment 96488 [details] Patch
I think this patch is in a good shape to be reviewed, I still want to remove the limitation of 10 arguments, but it is a minor change.
Comment on attachment 96488 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96488&action=review > Source/WebCore/bridge/qt/qt_runtime.h:224 > + JSObjectRef m_receiver; > + JSObjectRef m_receiverFunction; These used to be protected, and now they aren't -- you probably want to gcProtect/Unprotect these if you want to maintain the same semantics as those that already exist
Created attachment 96503 [details] Patch
Comment on attachment 96503 [details] Patch This looks sensible to me, but i'll hold off on r+ for someone familiar with qt
(In reply to comment #5) > (From update of attachment 96503 [details]) > This looks sensible to me, but i'll hold off on r+ for someone familiar with qt "dry" r=me (dry since I'm not yet a reviewer)
Comment on attachment 96503 [details] Patch rs=me based on Noam's assessment.
Comment on attachment 96503 [details] Patch Clearing flags on attachment: 96503 Committed r88635: <http://trac.webkit.org/changeset/88635>
All reviewed patches have been landed. Closing bug.