Bug 93880 – [Qt] Clean up exception handling

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Hausmann]

[Qt] Clean up exception handling

[Simon Hausmann]

Created attachment 158070 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 158070 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158070&action=review

> Source/WebCore/ChangeLog:10
> +        was thrown. Naturally the caller must store that ValueRef on the stack in order to get caught
> +        by the garbage collector, otherwise the callee would have to use JSValueProtect on it.

you want it to be garbage collected?

[Simon Hausmann]

(In reply to comment #2)
> (From update of attachment 158070 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=158070&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +        was thrown. Naturally the caller must store that ValueRef on the stack in order to get caught
> > +        by the garbage collector, otherwise the callee would have to use JSValueProtect on it.
> 
> you want it to be garbage collected?

No :) caught in the sense of _marked_ so that the GC does not delete it on the heap.

[Kenneth Rohde Christiansen]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 158070 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=158070&action=review
> > 
> > > Source/WebCore/ChangeLog:10
> > > +        was thrown. Naturally the caller must store that ValueRef on the stack in order to get caught
> > > +        by the garbage collector, otherwise the callee would have to use JSValueProtect on it.
> > 
> > you want it to be garbage collected?
> 
> No :) caught in the sense of _marked_ so that the GC does not delete it on the heap.

I guessed so, maybe that could be rewritten to be more clear for non JS guys like me.

[Simon Hausmann]

(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > (From update of attachment 158070 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=158070&action=review
> > > 
> > > > Source/WebCore/ChangeLog:10
> > > > +        was thrown. Naturally the caller must store that ValueRef on the stack in order to get caught
> > > > +        by the garbage collector, otherwise the callee would have to use JSValueProtect on it.
> > > 
> > > you want it to be garbage collected?
> > 
> > No :) caught in the sense of _marked_ so that the GC does not delete it on the heap.
> 
> I guessed so, maybe that could be rewritten to be more clear for non JS guys like me.

Good point, will do :)

[Caio Marcelo de Oliveira Filho]

LGTM.

[Simon Hausmann]

Committed r125439: <http://trac.webkit.org/changeset/125439>