[Qt] Remove Qt 4 specific code paths

[Simon Hausmann]

The maintenance of the Qt 4 and Qt 5 code paths in trunk is becoming expensive and we would like to do changes that will be even more difficult to maintain across two major versions, such as the introduction of the QtWebKitWidgets modules. Therefore this bug tracks the removal of the Qt 4 specific code paths in trunk based on the proposal and discussion at

    http://lists.webkit.org/pipermail/webkit-qt/2012-May/thread.html#2732

[Kenneth Rohde Christiansen]

Can we now change our signals and slots to the new Qt5 syntax? :-)

[Simon Hausmann]

I'm going to tackle this a bit later, unless somebody beats me to it. Prioritizing the Qt beta and my vacation first :)

[Simon Hausmann]

Created attachment 153244 [details]
Patch

[Simon Hausmann]

This patch is not for immediate landing, it will need to be synchronized with updates to build.webkit.org. But let's start here and let the EWS chew on it :)

[Early Warning System Bot]

Comment on attachment 153244 [details]
Patch

Attachment 153244 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13270896

[Csaba Osztrogonác]

When will we plan dropping Qt 4 build support for trunk?

[Simon Hausmann]

(In reply to comment #6)
> When will we plan dropping Qt 4 build support for trunk?

What's a good time for you? Next week? Let's talk on IRC how we could do this with regards to the bots.

At the least I guess we have to wait for the test rebasing to finish.

[Alexis Menard (darktears)]

(In reply to comment #7)
> (In reply to comment #6)
> > When will we plan dropping Qt 4 build support for trunk?
> 
> What's a good time for you? Next week? Let's talk on IRC how we could do this with regards to the bots.
> 
> At the least I guess we have to wait for the test rebasing to finish.

And also to stick with a version on Qt5. I really don't have time to take care of the bot every week to update the sha. I'd rather stick with a beta or something like that, with a guarantee that sanity checks were run on Mac OS.

[Simon Hausmann]

(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #6)
> > > When will we plan dropping Qt 4 build support for trunk?
> > 
> > What's a good time for you? Next week? Let's talk on IRC how we could do this with regards to the bots.
> > 
> > At the least I guess we have to wait for the test rebasing to finish.
> 
> And also to stick with a version on Qt5. I really don't have time to take care of the bot every week to update the sha. 

If maintenance of the mac bot is a time problem, is there somebody else in your team who could help with it?

[Alexis Menard (darktears)]

(In reply to comment #9)
> (In reply to comment #8)
> > (In reply to comment #7)
> > > (In reply to comment #6)
> > > > When will we plan dropping Qt 4 build support for trunk?
> > > 
> > > What's a good time for you? Next week? Let's talk on IRC how we could do this with regards to the bots.
> > > 
> > > At the least I guess we have to wait for the test rebasing to finish.
> > 
> > And also to stick with a version on Qt5. I really don't have time to take care of the bot every week to update the sha. 
> 
> If maintenance of the mac bot is a time problem, is there somebody else in your team who could help with it?

Well it's just that we have a crappy MacBook Pro and it's slow to "try" things.

[Simon Hausmann]

Created attachment 156049 [details]
Patch

Rebased patch

[Kenneth Rohde Christiansen]

Comment on attachment 156049 [details]
Patch

r=me, nice stuff

[Simon Hausmann]

Committed r124879: <http://trac.webkit.org/changeset/124879>