Bug 93462 - [Qt] Add unit test for QObject bindings for scriptable plugins
Summary: [Qt] Add unit test for QObject bindings for scriptable plugins
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Hausmann
URL:
Keywords:
Depends on:
Blocks: 60842
  Show dependency treegraph
 
Reported: 2012-08-08 04:44 PDT by Simon Hausmann
Modified: 2012-08-08 06:14 PDT (History)
0 users

See Also:


Attachments
Patch (3.05 KB, patch)
2012-08-08 04:48 PDT, Simon Hausmann
kenneth: review+
hausmann: commit-queue?
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Hausmann 2012-08-08 04:44:57 PDT
[Qt] Add unit test for QObject bindings for scriptable plugins
Comment 1 Simon Hausmann 2012-08-08 04:48:01 PDT
Created attachment 157182 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-08-08 05:04:17 PDT
Comment on attachment 157182 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157182&action=review

> Source/WebKit/qt/tests/qobjectbridge/tst_qobjectbridge.cpp:2189
> +    TestPluginWidget()
> +    { }

why on separate line?

> Source/WebKit/qt/tests/qobjectbridge/tst_qobjectbridge.cpp:2192
> +    int slotWithReturnValue() { return 42; }

Lovely number :-)

> Source/WebKit/qt/tests/qobjectbridge/tst_qobjectbridge.cpp:2206
> +    virtual QObject *createPlugin(const QString &, const QUrl &, const QStringList &, const QStringList &)

why not webkit style?
Comment 3 Simon Hausmann 2012-08-08 06:12:20 PDT
(In reply to comment #2)
> (From update of attachment 157182 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=157182&action=review
> 
> > Source/WebKit/qt/tests/qobjectbridge/tst_qobjectbridge.cpp:2189
> > +    TestPluginWidget()
> > +    { }
> 
> why on separate line?

OOps.

> > Source/WebKit/qt/tests/qobjectbridge/tst_qobjectbridge.cpp:2192
> > +    int slotWithReturnValue() { return 42; }
> 
> Lovely number :-)
> 
> > Source/WebKit/qt/tests/qobjectbridge/tst_qobjectbridge.cpp:2206
> > +    virtual QObject *createPlugin(const QString &, const QUrl &, const QStringList &, const QStringList &)
> 
> why not webkit style?

Thanks, will fix these before landing.
Comment 4 Simon Hausmann 2012-08-08 06:14:37 PDT
Committed r125029: <http://trac.webkit.org/changeset/125029>