[Qt] Add unit test for QObject bindings for scriptable plugins
Created attachment 157182 [details] Patch
Comment on attachment 157182 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157182&action=review > Source/WebKit/qt/tests/qobjectbridge/tst_qobjectbridge.cpp:2189 > + TestPluginWidget() > + { } why on separate line? > Source/WebKit/qt/tests/qobjectbridge/tst_qobjectbridge.cpp:2192 > + int slotWithReturnValue() { return 42; } Lovely number :-) > Source/WebKit/qt/tests/qobjectbridge/tst_qobjectbridge.cpp:2206 > + virtual QObject *createPlugin(const QString &, const QUrl &, const QStringList &, const QStringList &) why not webkit style?
(In reply to comment #2) > (From update of attachment 157182 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=157182&action=review > > > Source/WebKit/qt/tests/qobjectbridge/tst_qobjectbridge.cpp:2189 > > + TestPluginWidget() > > + { } > > why on separate line? OOps. > > Source/WebKit/qt/tests/qobjectbridge/tst_qobjectbridge.cpp:2192 > > + int slotWithReturnValue() { return 42; } > > Lovely number :-) > > > Source/WebKit/qt/tests/qobjectbridge/tst_qobjectbridge.cpp:2206 > > + virtual QObject *createPlugin(const QString &, const QUrl &, const QStringList &, const QStringList &) > > why not webkit style? Thanks, will fix these before landing.
Committed r125029: <http://trac.webkit.org/changeset/125029>