Bug 39746 - [Qt] qt_runtime.h and .cpp have coding-style errors
Summary: [Qt] qt_runtime.h and .cpp have coding-style errors
Status: RESOLVED DUPLICATE of bug 60842
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P5 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
: 39747 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-05-26 09:32 PDT by Anders Bakken
Modified: 2011-05-22 23:50 PDT (History)
8 users (show)

See Also:

Attachments
Patch that fixes the coding style issues (4.13 KB, patch)
2010-05-26 09:57 PDT, Anders Bakken 		no flags Details | Formatted Diff | Diff
Patch that fixes the coding style issues (71.89 KB, patch)
2010-05-26 10:11 PDT, Anders Bakken 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Bakken 2010-05-26 09:32:44 PDT 
WebCore/bridge/qt/qt_runtime.h:20:  #ifndef header guard has wrong style, please use: qt_runtime_h  [build/header_guard] [5]
WebCore/bridge/qt/qt_runtime.h:76:  This { should be at the end of the previous line  [whitespace/braces] [4]
WebCore/bridge/qt/qt_runtime.h:98:  This { should be at the end of the previous line  [whitespace/braces] [4]
WebCore/bridge/qt/qt_runtime.h:170:  This { should be at the end of the previous line  [whitespace/braces] [4]
WebCore/bridge/qt/qt_runtime.h:181:  d_func is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/bridge/qt/qt_runtime.h:193:  This { should be at the end of the previous line  [whitespace/braces] [4]
WebCore/bridge/qt/qt_runtime.h:195:  Extra space before )  [whitespace/parens] [2]
WebCore/bridge/qt/qt_runtime.h:202:  d_func is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/bridge/qt/qt_runtime.h:213:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 9 in 1 files
Comment 1 Anders Bakken 2010-05-26 09:57:29 PDT 
Created attachment 57108 [details]
Patch that fixes the coding style issues
Comment 2 Anders Bakken 2010-05-26 10:09:49 PDT 
*** Bug 39747 has been marked as a duplicate of this bug. ***
Comment 3 Anders Bakken 2010-05-26 10:11:46 PDT 
Created attachment 57112 [details]
Patch that fixes the coding style issues
Comment 4 Petri Ojala 2010-05-26 21:39:49 PDT 
QtTriaged
Comment 5 Jesus Sanchez-Palencia 2010-06-29 10:15:46 PDT 
Is this waiting for review? Maybe Anders forgot the flag...
Comment 6 Benjamin Poulain 2011-01-07 11:40:57 PST 
Anders, what is the status of this?
Comment 7 manish_c_mulimani 2011-05-22 23:34:11 PDT 
There is no activity on this bug from a long time. So can I assign it to myself and take it further?
Comment 8 Andreas Kling 2011-05-22 23:48:55 PDT 
(In reply to comment #7)
> There is no activity on this bug from a long time. So can I assign it to myself and take it further?

Given that Noam is currently rewriting this code, I'd suggest you sync with him (noamr on #qtwebkit) :)
Comment 9 Noam Rosenthal 2011-05-22 23:50:25 PDT 

*** This bug has been marked as a duplicate of bug 60842 ***