Bug 48728

Summary:

test-webkitpy fails when run with Win32 Python

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

ASSIGNED

Severity:

Normal

CC:

abarth, ddkilzer, dglazkov, dpranke, eric, koz, mihaip, paroga

Priority:

Keywords:

PlatformOnly

Version:

528+ (Nightly build)

Hardware:

OS:

Windows XP

Bug Depends on:

49472, 54525, 54526, 54527, 48072, 48883, 49033, 49474, 49475, 49476, 53822, 54520, 54699, 54700, 54703, 54709, 54788, 54790, 64950, 64959

Bug Blocks:

48166, 48517

Attachments:

Description	Flags
Rollup patch of all of the changes necessary to get test-webkitpy to run cleanly on win32	none
Patch to blacklist failing test suites - obsolete, moving to a different bug.	none

Adam Roben (:aroben)

Reported 2010-10-31 09:44:46 PDT

Lots of tests fail when you run test-webkitpy with Win32 Python. I believe this is currently expected, but we should fix it! I'll use this as an umbrella bug and block it on individual fixes.

Attachments
Rollup patch of all of the changes necessary to get test-webkitpy to run cleanly on win32 (21.84 KB, patch) 2011-02-15 19:59 PST, Dirk Pranke	no flags	Details Formatted Diff Diff
Patch to blacklist failing test suites - obsolete, moving to a different bug. (2.20 KB, patch) 2011-02-17 19:11 PST, Dirk Pranke	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Dimitri Glazkov (Google)

Comment 1 2010-10-31 09:58:46 PDT

Dirk Pranke

Comment 2 2011-02-15 19:59:36 PST

Created attachment 82578 [details] Rollup patch of all of the changes necessary to get test-webkitpy to run cleanly on win32

Dirk Pranke

Comment 3 2011-02-15 20:00:57 PST

I've attached a roll-up patch ... if you apply it, test-webkitpy should run cleanly. I will break the patch up into smaller chunks for review and file a few sub-bugs to track particular issues that we might want to consider.

Dirk Pranke

Comment 4 2011-02-17 19:11:14 PST

Created attachment 82899 [details] Patch to blacklist failing test suites - obsolete, moving to a different bug.

Adam Roben (:aroben)

Comment 5 2011-02-17 19:24:24 PST

Comment on attachment 82899 [details] Patch to blacklist failing test suites - obsolete, moving to a different bug. Dirk, would you mind filing a new bug for this patch? It would be nice to keep this one as an umbrella for fixing the real issues, not just skipping the tests. (Skipping them for now does seem like the right strategy, though.)

Dirk Pranke

Comment 6 2011-02-17 19:35:40 PST

Sure. I was thinking of leaving this bug open and just landing this patch, but a separate bug is fine, too.

Dirk Pranke

Comment 7 2011-02-23 19:41:59 PST

I've fixed all of the bugs I plan to fix as of now, so I'm disclaiming ownership of this :)

Note You need to log in before you can comment on or make changes to this bug.