Bug 40833

Summary: [GTK] The GTK+ EventSender needs support for beginDragWithFiles
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: joone, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 40832, 52097    
Bug Blocks: 52094, 52090, 52092, 52096    
Attachments:
Description Flags
proposed patch
none
updated patch
none
Patch none

Martin Robinson
Reported 2010-06-18 08:02:48 PDT
This is required for a bunch of drag-and-drop tests to pass.
Attachments
proposed patch (6.12 KB, patch)
2010-11-19 05:50 PST, Adam Bergkvist
no flags
updated patch (6.12 KB, patch)
2010-11-19 08:23 PST, Adam Bergkvist
no flags
Patch (16.91 KB, patch)
2011-01-07 18:17 PST, Martin Robinson
no flags
Martin Robinson
Comment 1 2010-09-10 08:46:43 PDT
*** Bug 34246 has been marked as a duplicate of this bug. ***
Adam Bergkvist
Comment 2 2010-11-19 05:50:37 PST
Created attachment 74376 [details] proposed patch The patch has been tested with LayoutTests/fast/files (requires building with --blob, see build fix https://bugs.webkit.org/show_bug.cgi?id=49724).
WebKit Review Bot
Comment 3 2010-11-19 05:52:20 PST
Attachment 74376 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebKitTools/ChangeLog', u'WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp', u'WebKitTools/DumpRenderTree/gtk/EventSender.cpp', u'WebKitTools/DumpRenderTree/gtk/EventSender.h']" exit_code: 1 WebKitTools/DumpRenderTree/gtk/EventSender.cpp:421: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Adam Bergkvist
Comment 4 2010-11-19 08:23:35 PST
Created attachment 74393 [details] updated patch Fixed style error.
Martin Robinson
Comment 5 2010-11-19 09:21:08 PST
We should wait to land this about File support is implemented. After that I think we should unskip as many of the files that are failing in the Skipped list because of this issue that we can.
Martin Robinson
Comment 6 2011-01-07 18:17:37 PST
Martin Robinson
Comment 7 2011-01-07 18:18:43 PST
I've merged my earlier work on this issue with Adam's patch and together we've unskipped tests and organized the remaining failures. Attached is the result of that work.
Martin Robinson
Comment 8 2011-01-07 18:42:08 PST
Comment on attachment 78296 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78296&action=review > LayoutTests/platform/gtk/Skipped:5355 > +editing/pasteboard/file-drag-to-editable.html: If everything else is okay, I can fix this broken Skipped line before landing.
Gustavo Noronha (kov)
Comment 9 2011-01-18 04:38:59 PST
Comment on attachment 78296 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78296&action=review Looks good! > Tools/DumpRenderTree/gtk/EventSender.cpp:439 > + GFile* testFile = g_file_new_for_uri(mainFrameURI); We should be able to use GRefPtr here, since we're using GOwnPtr for the chars =)? > Tools/DumpRenderTree/gtk/EventSender.cpp:452 > + parentDirectory = g_file_new_for_path(currentDirectory.get()); You're leaking the parentDirectory returned by g_file_get_parent() here. Perhaps fix this just by using GRefPtr on it as well =).
Martin Robinson
Comment 10 2011-01-18 09:18:32 PST
(In reply to comment #9) > You're leaking the parentDirectory returned by g_file_get_parent() here. Perhaps fix this just by using GRefPtr on it as well =). Thanks for the review! I will fix these issues before landing by switching all raw GFile references to GRefPtr.
Martin Robinson
Comment 11 2011-01-18 09:52:16 PST
Note You need to log in before you can comment on or make changes to this bug.