Bug 49724 – [GTK] Building with Blob support fails

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Adam Bergkvist]

Building with --blob fails.

[Adam Bergkvist]

Created attachment 74226 [details]
proposed patch

Build fix.

[WebKit Review Bot]

Attachment 74226 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/6131059

[Adam Bergkvist]

Created attachment 74374 [details]
updated patch

Updated patch.

JSArrayBufferViewCustom.cpp was removed in r72343.

[WebKit Commit Bot]

Comment on attachment 74374 [details]
updated patch

Rejecting patch 74374 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 74374]" exit_code: 1
Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=74374&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=49724&ctype=xml
Processing 1 patch from 1 bug.
Cleaning working directory
Updating working directory
Processing patch 74374 from bug 49724.
ERROR: /Projects/CommitQueue/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/6152071

[Adam Bergkvist]

Created attachment 74542 [details]
updated patch

Sorry, ChangeLog "Reviewed by"-line was missing in the previous patch.

[WebKit Commit Bot]

Comment on attachment 74542 [details]
updated patch

Rejecting patch 74542 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', 74542]" exit_code: 2
Last 500 characters of output:
AILED at 666.
Hunk #3 succeeded at 746 with fuzz 2 (offset 11 lines).
Hunk #4 succeeded at 778 (offset 11 lines).
Hunk #5 FAILED at 823.
Hunk #6 succeeded at 1506 (offset 21 lines).
Hunk #7 succeeded at 1523 (offset 21 lines).
2 out of 7 hunks FAILED -- saving rejects to file WebCore/GNUmakefile.am.rej
patching file WebCore/platform/gtk/FileSystemGtk.cpp

Failed to run "[u'/Users/abarth/git/webkit-queue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Martin Robinson', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/6364012

[Martin Robinson]

Adam, I think you need to update this patch to ToT again. :/

[Adam Bergkvist]

Created attachment 74659 [details]
updated patch

Here we go again.

[WebKit Commit Bot]

Comment on attachment 74659 [details]
updated patch

Clearing flags on attachment: 74659

Committed r72614: <http://trac.webkit.org/changeset/72614>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.