RESOLVED FIXED 52096
[GTK] Filenames are converted to URLs during edit drags 
https://bugs.webkit.org/show_bug.cgi?id=52096
Summary [GTK] Filenames are converted to URLs during edit drags
Martin Robinson
Reported 2011-01-07 18:02:30 PST
This is a companion fix to https://bugs.webkit.org/show_bug.cgi?id=38826. It can be observed by the failure of editing/pasteboard/file-drag-to-editable.html.
Attachments
Patch (3.08 KB, patch)
2011-01-07 18:55 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2011-01-07 18:55:35 PST
Created attachment 78298 [details] Patch
Eric Seidel (no email)
Comment 2 2011-01-10 13:48:03 PST
Comment on attachment 78298 [details] Patch I'm confused by what you're doing for local files. Is this tested?
Martin Robinson
Comment 3 2011-01-10 13:51:40 PST
(In reply to comment #2) > (From update of attachment 78298 [details]) > I'm confused by what you're doing for local files. Is this tested? Essentially, during edit drags, filenames should not be advertised as a URL on the drag, but otherwise they should be. This bug was fixed for Chromium (and Mac I believe) in https://bugs.webkit.org/show_bug.cgi?id=38826. The test in that bug relied on beginDragWithFiles, so it didn't fail on GTK+ at the time (it was skipped). This patch fixes the bug and unskips the test in question (it depends on the landing of beginDragWithFiles) patch.
Martin Robinson
Comment 4 2011-01-10 13:51:41 PST
(In reply to comment #2) > (From update of attachment 78298 [details]) > I'm confused by what you're doing for local files. Is this tested? Essentially, during edit drags, filenames should not be advertised as a URL on the drag, but otherwise they should be. This bug was fixed for Chromium (and Mac I believe) in https://bugs.webkit.org/show_bug.cgi?id=38826. The test in that bug relied on beginDragWithFiles, so it didn't fail on GTK+ at the time (it was skipped). This patch fixes the bug and unskips the test in question (it depends on the landing of beginDragWithFiles) patch.
Eric Seidel (no email)
Comment 5 2011-01-11 03:05:33 PST
Comment on attachment 78298 [details] Patch OK.
Martin Robinson
Comment 6 2011-01-18 11:06:34 PST
Committed r76039: <http://trac.webkit.org/changeset/76039>
Note You need to log in before you can comment on or make changes to this bug.