Bug 52090 - [Soup] ResourceHandleSoup does not ever call didSendData for file uploads
Summary: [Soup] ResourceHandleSoup does not ever call didSendData for file uploads
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on: 40833
Blocks:
  Show dependency treegraph
 
Reported: 2011-01-07 17:02 PST by Martin Robinson
Modified: 2011-02-10 12:33 PST (History)
1 user (show)

See Also:


Attachments
Patch (10.61 KB, patch)
2011-01-10 01:45 PST, Martin Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2011-01-07 17:02:26 PST
This will break http/tests/local/formdata/upload-events.html when beginDragWithFiles lands.
Comment 1 Martin Robinson 2011-01-10 01:45:24 PST
Created attachment 78380 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2011-02-10 11:11:01 PST
Comment on attachment 78380 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=78380&action=review

Looks great!

> WebCore/platform/network/soup/ResourceHandleSoup.cpp:261
> +    ASSERT(buffer);

I'd move this ASSERT up to be the first thing that is done.
Comment 3 Martin Robinson 2011-02-10 12:27:13 PST
Committed r78257: <http://trac.webkit.org/changeset/78257>
Comment 4 Martin Robinson 2011-02-10 12:33:45 PST
Comment on attachment 78380 [details]
Patch

Thanks for the review. Landed after moving the ASSERT up and unskipping a few other tests in the skipped list.