Bug 234932

Summary: check-webkit-style: add checker for unexpected fall through after ASSERT_NOT_REACHED() statements
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ews-watchlist, glenn, jbedard, katherine_cheney, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=234852
Bug Depends on:    
Bug Blocks: 234964, 234965, 234967, 234971, 235037, 234944, 234975, 234986, 234989, 234991    
Attachments:
Description Flags
Patch v1 none

Description David Kilzer (:ddkilzer) 2022-01-06 12:22:50 PST 
check-webkit-style: add checker for unexpected fall through after ASSERT_NOT_REACHED() statements.

Would have found issues like this:

Bug 234852: CrashTracer: com.apple.WebKit.Networking at com.apple.WebKit: WebKit::ResourceLoadStatisticsDatabaseStore::cookieAccess
<https://bugs.webkit.org/show_bug.cgi?id=234852>
Comment 1 Radar WebKit Bug Importer 2022-01-06 12:23:38 PST 
<rdar://problem/87213520>
Comment 2 David Kilzer (:ddkilzer) 2022-01-06 12:57:16 PST 
Created attachment 448529 [details]
Patch v1
Comment 3 Brent Fulgham 2022-01-07 10:56:47 PST 
Comment on attachment 448529 [details]
Patch v1

Looks good. Thank you for doing this.
Comment 4 EWS 2022-01-07 14:59:08 PST 
Committed r287789 (245849@main): <https://commits.webkit.org/245849@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448529 [details].