Bug 234989 – WebKit::nsTextAlignmentFromTextAlignment() falls through ASSERT_NOT_REACHED()

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[David Kilzer (:ddkilzer)]

WebKit::nsTextAlignmentFromTextAlignment() falls through ASSERT_NOT_REACHED().

In the `default` case, `nsTextAlignment` is returned uninitialized.

static NSTextAlignment nsTextAlignmentFromTextAlignment(TextAlignment textAlignment)
{   
    NSTextAlignment nsTextAlignment;
    switch (textAlignment) {
    case NoAlignment:
        nsTextAlignment = NSTextAlignmentNatural;
        break;
    case LeftAlignment: 
        nsTextAlignment = NSTextAlignmentLeft;
        break;
    case RightAlignment:
        nsTextAlignment = NSTextAlignmentRight;
        break;
    case CenterAlignment: 
        nsTextAlignment = NSTextAlignmentCenter;
        break;
    case JustifiedAlignment:
        nsTextAlignment = NSTextAlignmentJustified;
        break;
    default:
        ASSERT_NOT_REACHED();
    }
    
    return nsTextAlignment;
}

See Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm.

[Radar WebKit Bug Importer]

<rdar://problem/87273264>

[Chris Dumez]

Created attachment 449494 [details]
Patch

[EWS]

Committed r288241 (246195@main): <https://commits.webkit.org/246195@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449494 [details].