Bug 234975 – WebKit::DownloadProxy::publishProgress() falls through ASSERT_NOT_REACHED()

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[David Kilzer (:ddkilzer)]

WebKit::DownloadProxy::publishProgress() falls through ASSERT_NOT_REACHED().

There should be an early return in the `else` block after ASSERT_NOT_REACHED().

#if PLATFORM(COCOA)
void DownloadProxy::publishProgress(const URL& URL)
{
    if (!m_dataStore)
        return;

    SandboxExtension::Handle handle;
    if (auto createdHandle = SandboxExtension::createHandle(URL.fileSystemPath(), SandboxExtension::Type::ReadWrite))
        handle = WTFMove(*createdHandle);
    else
        ASSERT_NOT_REACHED();

    m_dataStore->networkProcess().send(Messages::NetworkProcess::PublishDownloadProgress(m_downloadID, URL, handle), 0);
}
#endif // PLATFORM(COCOA)

See Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp.

[Radar WebKit Bug Importer]

<rdar://problem/87265153>

[Chris Dumez]

Created attachment 449491 [details]
Patch

[EWS]

Committed r288232 (246189@main): <https://commits.webkit.org/246189@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449491 [details].