Bug 234971 – JSC::JSWebAssemblyModule::createStub() falls through ASSERT_NOT_REACHED()

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: JavaScriptCore

[David Kilzer (:ddkilzer)]

JSC::JSWebAssemblyModule::createStub() falls through ASSERT_NOT_REACHED().

These fall-throughs should either use RELEASE_ASSERT_NOT_REACHED(), or add a `return nullptr;` statement after ASSERT_NOT_REACHED().

Presumably the switch statement will never fall through unless there is memory corruption, so a RELEASE_ASSERT_NOT_REACHED() would catch such corruption much earlier.

JSWebAssemblyModule* JSWebAssemblyModule::createStub(VM& vm, JSGlobalObject* globalObject, Structure* structure, Wasm::Module::ValidationResult&& result)
{
    [...]
    auto error = module->generateWasmToJSStubs(vm);
    if (UNLIKELY(!error)) {
        switch (error.error()) {
        case Wasm::BindingFailure::OutOfMemory:
            throwException(globalObject, scope, createJSWebAssemblyLinkError(globalObject, vm, "Out of executable memory"_s));
            return nullptr;
        }
        ASSERT_NOT_REACHED();
    }
    return module;
}

See Source/JavaScriptCore/wasm/js/JSWebAssemblyModule.cpp.

[Radar WebKit Bug Importer]

<rdar://problem/87262829>

[Sergey Rubanov]

createStub() was removed when stub generation moved to compiler threads (bug https://bugs.webkit.org/show_bug.cgi?id=274721 / https://github.com/WebKit/WebKit/commit/c9a03e0c8a96).
The ASSERT_NOT_REACHED fall-through is gone. Closing as RESOLVED / FIXED.

[David Kilzer (:ddkilzer)]

This code was removed from WebKit in 279275@main (bug 274636, rdar://128663255), which deleted the ASSERT_NOT_REACHED() fall-through along with generateWasmToJSStubs().

[David Kilzer (:ddkilzer)]

*** This bug has been marked as a duplicate of bug 274636 ***