Bug 212718

Summary:

tvOS and watchOS should build with the public SDK

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, changseok, dino, eric.carlson, esprehn+autocc, ews-watchlist, glenn, graouts, gyuyoung.kim, jer.noble, keith_miller, kondapallykalyan, mark.lam, msaboff, philipj, saam, sergio, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

Attachments:

Description	Flags
Patch	none

Jonathan Bedard

Reported 2020-06-03 15:13:57 PDT

We should add watchOS and tvOS to WebKit's public infrastructure. Of particular interest is EWS.

Attachments
Patch (181.57 KB, patch) 2020-06-04 10:03 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Jonathan Bedard

Comment 1 2020-06-03 15:14:37 PDT

<rdar://problem/56477494>

Jonathan Bedard

Comment 2 2020-06-04 10:03:51 PDT

Created attachment 401032 [details] Patch

EWS Watchlist

Comment 3 2020-06-04 10:04:58 PDT

Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE

Jonathan Bedard

Comment 4 2020-06-04 10:18:34 PDT

The patch on this bug is being broken up into multiple changes, but should be sufficient to build watchOS and tvOS both Simulator and device with a public SDK.

Jonathan Bedard

Comment 5 2020-06-12 11:45:19 PDT

Everything has been landed, doing final verification locally before closing this bug.

Jonathan Bedard

Comment 6 2020-06-12 13:00:49 PDT

I have verified the following all work: build-webkit --wathos-device build-webkit --wathos-simulator build-webkit --tvos-device build-webkit --tvos-simulator CI + EWS has confirmed I haven't broken iOS. I think it's time to close this bug!

Note You need to log in before you can comment on or make changes to this bug.