Bug 212996 - WebKit:Add PepperUICoreSPI.h
Summary: WebKit:Add PepperUICoreSPI.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-09 15:23 PDT by Jonathan Bedard
Modified: 2020-06-10 17:00 PDT (History)
5 users (show)

See Also:

Attachments
Patch (25.05 KB, patch)
2020-06-09 15:33 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (25.10 KB, patch)
2020-06-10 07:55 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (24.90 KB, patch)
2020-06-10 11:25 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-06-09 15:23:18 PDT 
To build watchOS, we need an SPI header for PepperUICore.
Comment 1 Radar WebKit Bug Importer 2020-06-09 15:23:36 PDT 
<rdar://problem/64182627>
Comment 2 Jonathan Bedard 2020-06-09 15:33:13 PDT 
Created attachment 401483 [details]
Patch
Comment 3 Jonathan Bedard 2020-06-10 07:55:04 PDT 
Created attachment 401541 [details]
Patch
Comment 4 Tim Horton 2020-06-10 10:41:22 PDT 
Comment on attachment 401541 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401541&action=review

> Source/WebKit/Platform/spi/watchos/PepperUICoreSPI.h:157
> +@property (nonatomic, assign) UIReturnKeyType returnKeyType; // Default is Done, also supports Send and Join

I think we shouldn't be in the habit of importing comments from SPI headers.

> Source/WebKit/Platform/spi/watchos/PepperUICoreSPI.h:280
> +@property (nonatomic) BOOL useWideIdleCheck;

Do we really use all this stuff? I don't think so.
Comment 5 Tim Horton 2020-06-10 10:43:56 PDT 
We do. Nevermind.
Comment 6 Jonathan Bedard 2020-06-10 11:19:33 PDT 
Comment on attachment 401541 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401541&action=review

>> Source/WebKit/Platform/spi/watchos/PepperUICoreSPI.h:157
>> +@property (nonatomic, assign) UIReturnKeyType returnKeyType; // Default is Done, also supports Send and Join
> 
> I think we shouldn't be in the habit of importing comments from SPI headers.

I mostly scrubbed them, missed this one.
Comment 7 Jonathan Bedard 2020-06-10 11:25:32 PDT 
Created attachment 401558 [details]
Patch
Comment 8 EWS 2020-06-10 13:34:23 PDT 
Committed r262854: <https://trac.webkit.org/changeset/262854>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401558 [details].
Comment 9 Jonathan Bedard 2020-06-10 16:05:13 PDT 
Committed r262868: <https://trac.webkit.org/changeset/262868>
Comment 10 Jonathan Bedard 2020-06-10 17:00:13 PDT 
Committed r262875: <https://trac.webkit.org/changeset/262875>