RESOLVED FIXED 212853
WebCore: Add tvOS and watchOS SPI headers 
https://bugs.webkit.org/show_bug.cgi?id=212853
Summary WebCore: Add tvOS and watchOS SPI headers
Jonathan Bedard
Reported 2020-06-05 15:52:03 PDT
tvOS and watchOS need a few SPI headers to build WebCore.
Attachments
Patch (10.82 KB, patch)
2020-06-05 16:09 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (10.33 KB, patch)
2020-06-05 16:35 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (9.48 KB, patch)
2020-06-08 08:43 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (10.27 KB, patch)
2020-06-08 09:06 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-06-05 15:52:31 PDT
<rdar://problem/64048485>
Jonathan Bedard
Comment 2 2020-06-05 16:09:05 PDT
Created attachment 401212 [details] Patch
Jonathan Bedard
Comment 3 2020-06-05 16:35:32 PDT
Created attachment 401215 [details] Patch
Andy Estes
Comment 4 2020-06-05 21:27:42 PDT
Comment on attachment 401215 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401215&action=review > Source/WebCore/PAL/pal/spi/cocoa/CoreMotionSPI.h:30 > +#if defined __has_include && __has_include(<CoreMotion/CoreMotion.h>) > +#import <CoreMotion/CoreMotion.h> > +#else "Guidelines for using SPI in WebKit" (see link in radar) says to include SDK headers based on USE(APPLE_INTERNAL_SDK) macros and PLATFORM() macros rather than __has_include() (because we want to detect if an SDK header unexpectedly goes away). > Source/WebCore/platform/ios/WebCoreMotionManager.h:29 > -#import <CoreMotion/CoreMotion.h> > +#import <pal/spi/cocoa/CoreMotionSPI.h> Not new to your change, but do we really need this include? Seems like we just need to forward-declare CMMotionManager.
Jonathan Bedard
Comment 5 2020-06-08 08:43:37 PDT
Created attachment 401341 [details] Patch
Jonathan Bedard
Comment 6 2020-06-08 09:06:18 PDT
Created attachment 401342 [details] Patch
EWS
Comment 7 2020-06-08 10:52:21 PDT
Committed r262725: <https://trac.webkit.org/changeset/262725> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401342 [details].
Note You need to log in before you can comment on or make changes to this bug.