tvOS and watchOS need a few SPI headers to build WebCore.
<rdar://problem/64048485>
Created attachment 401212 [details] Patch
Created attachment 401215 [details] Patch
Comment on attachment 401215 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401215&action=review > Source/WebCore/PAL/pal/spi/cocoa/CoreMotionSPI.h:30 > +#if defined __has_include && __has_include(<CoreMotion/CoreMotion.h>) > +#import <CoreMotion/CoreMotion.h> > +#else "Guidelines for using SPI in WebKit" (see link in radar) says to include SDK headers based on USE(APPLE_INTERNAL_SDK) macros and PLATFORM() macros rather than __has_include() (because we want to detect if an SDK header unexpectedly goes away). > Source/WebCore/platform/ios/WebCoreMotionManager.h:29 > -#import <CoreMotion/CoreMotion.h> > +#import <pal/spi/cocoa/CoreMotionSPI.h> Not new to your change, but do we really need this include? Seems like we just need to forward-declare CMMotionManager.
Created attachment 401341 [details] Patch
Created attachment 401342 [details] Patch
Committed r262725: <https://trac.webkit.org/changeset/262725> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401342 [details].