Bug 212796 – WTF: Exclude MachExceptions.defs from all embedded builds

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Template Framework

[Jonathan Bedard]

MachExceptions.defs is excluded from OpenSource iPhone builds, and should also be excluded from other OpenSource embedded builds.

[Jonathan Bedard]

Created attachment 401113 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 401113 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401113&action=review

> Source/WTF/ChangeLog:10
> [phone]  Jonathan Bedard  <[e-mail]>

Extra change log.

> Source/WTF/Configurations/WTF.xcconfig:-35
> -SYSTEM_FRAMEWORK_SEARCH_PATHS = $(inherited) $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks

This seems unrelated.

> Source/WTF/Configurations/WTF.xcconfig:32
> +EXCLUDED_SOURCE_FILE_NAMES[sdk=embedded*] = $(EXCLUDED_SOURCE_FILE_NAMES_$(USE_INTERNAL_SDK));

This includes simulator, correct?

[Jonathan Bedard]

Created attachment 401117 [details]
Patch

[Jonathan Bedard]

(In reply to Alexey Proskuryakov from comment #2)
> Comment on attachment 401113 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=401113&action=review
> 
> > Source/WTF/ChangeLog:10
> > [phone]  Jonathan Bedard  <[e-mail]>
> 
> Extra change log.
> 
> > Source/WTF/Configurations/WTF.xcconfig:-35
> > -SYSTEM_FRAMEWORK_SEARCH_PATHS = $(inherited) $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks
> 
> This seems unrelated.
> 
> > Source/WTF/Configurations/WTF.xcconfig:32
> > +EXCLUDED_SOURCE_FILE_NAMES[sdk=embedded*] = $(EXCLUDED_SOURCE_FILE_NAMES_$(USE_INTERNAL_SDK));
> 
> This includes simulator, correct?

It does, this same pattern will show up a few more times in other xcconfig files.

[EWS]

Committed r262597: <https://trac.webkit.org/changeset/262597>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401117 [details].

[Radar WebKit Bug Importer]

<rdar://problem/64033297>