Bug 213076 - WebKit: Guard requestDocumentContext with HAVE(UI_WK_DOCUMENT_CONTEXT)
Summary: WebKit: Guard requestDocumentContext with HAVE(UI_WK_DOCUMENT_CONTEXT)
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
Keywords: InRadar
Depends on:
Reported: 2020-06-11 08:03 PDT by Jonathan Bedard
Modified: 2020-06-11 12:42 PDT (History)
6 users (show)

See Also:

Patch (3.17 KB, patch)
2020-06-11 08:10 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-06-11 08:03:55 PDT
HAVE(UI_WK_DOCUMENT_CONTEXT) is only available on iOS and MacCaatalyst, watchOS and tvOS cannot retrieve document contexts.
Comment 1 Radar WebKit Bug Importer 2020-06-11 08:05:22 PDT
Comment 2 Jonathan Bedard 2020-06-11 08:10:01 PDT
Created attachment 401645 [details]
Comment 3 Jonathan Bedard 2020-06-11 08:11:45 PDT
I'm not totally certain about this change, but it strikes me as wrong that requestDocumentContext is used when HAVE(UI_WK_DOCUMENT_CONTEXT) is false.
Comment 4 Tim Horton 2020-06-11 10:46:35 PDT
Comment on attachment 401645 [details]

Seems fine to me.
Comment 5 EWS 2020-06-11 12:42:03 PDT
Committed r262917: <https://trac.webkit.org/changeset/262917>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401645 [details].