RESOLVED FIXED 213076
WebKit: Guard requestDocumentContext with HAVE(UI_WK_DOCUMENT_CONTEXT) 
https://bugs.webkit.org/show_bug.cgi?id=213076
Summary WebKit: Guard requestDocumentContext with HAVE(UI_WK_DOCUMENT_CONTEXT)
Jonathan Bedard
Reported 2020-06-11 08:03:55 PDT
HAVE(UI_WK_DOCUMENT_CONTEXT) is only available on iOS and MacCaatalyst, watchOS and tvOS cannot retrieve document contexts.
Attachments
Patch (3.17 KB, patch)
2020-06-11 08:10 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-06-11 08:05:22 PDT
<rdar://problem/64254698>
Jonathan Bedard
Comment 2 2020-06-11 08:10:01 PDT
Created attachment 401645 [details] Patch
Jonathan Bedard
Comment 3 2020-06-11 08:11:45 PDT
I'm not totally certain about this change, but it strikes me as wrong that requestDocumentContext is used when HAVE(UI_WK_DOCUMENT_CONTEXT) is false.
Tim Horton
Comment 4 2020-06-11 10:46:35 PDT
Comment on attachment 401645 [details] Patch Seems fine to me.
EWS
Comment 5 2020-06-11 12:42:03 PDT
Committed r262917: <https://trac.webkit.org/changeset/262917> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401645 [details].
Note You need to log in before you can comment on or make changes to this bug.