Bug 212834 – WebCore: Link to framework stubs for watchOS and tvOS

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Jonathan Bedard]

WebCore should link to framework stubs for watchOS and tvOS.

[Radar WebKit Bug Importer]

<rdar://problem/64033712>

[Jonathan Bedard]

Created attachment 401173 [details]
Patch

[Tim Horton]

Comment on attachment 401173 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401173&action=review

> Source/WebCore/Configurations/Base.xcconfig:79
> +GCC_WARN_64_TO_32_BIT_CONVERSION[arch=i386] = NO;

Wonder why we have it on at all at this point. Also, how did we not need this when we had 32-bit macOS builds?

[Tim Horton]

Comment on attachment 401173 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401173&action=review

> Source/WebCore/Configurations/WebCore.xcconfig:38
> +FRAMEWORK_SEARCH_PATHS = $(WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR) $(BUILT_PRODUCTS_DIR) $(WK_PRIVATE_FRAMEWORKS_DIR);

This seems a little out-of-scope. I can't imagine the harm (you should find what you're looking for in WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR), but it is a significant change for macOS.

[Jonathan Bedard]

Comment on attachment 401173 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401173&action=review

>> Source/WebCore/Configurations/Base.xcconfig:79
>> +GCC_WARN_64_TO_32_BIT_CONVERSION[arch=i386] = NO;
> 
> Wonder why we have it on at all at this point. Also, how did we not need this when we had 32-bit macOS builds?

My first thought was to actually fix the issues, there aren't very many. But most of them are in automatically generated code, so the fixes may have had other side effects. If we want to keep this on, it seems better to get EWS up and running first.

>> Source/WebCore/Configurations/WebCore.xcconfig:38
>> +FRAMEWORK_SEARCH_PATHS = $(WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR) $(BUILT_PRODUCTS_DIR) $(WK_PRIVATE_FRAMEWORKS_DIR);
> 
> This seems a little out-of-scope. I can't imagine the harm (you should find what you're looking for in WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR), but it is a significant change for macOS.

I guess wee really want this:

FRAMEWORK_SEARCH_PATHS[sdk=embeedded*] = $(WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR) $(BUILT_PRODUCTS_DIR) $(WK_PRIVATE_FRAMEWORKS_DIR);
FRAMEWORK_SEARCH_PATHS[sdk=macosx*] = $(WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR);

[Jonathan Bedard]

Created attachment 401189 [details]
Patch

[EWS]

Committed r262650: <https://trac.webkit.org/changeset/262650>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401189 [details].